Skip to content

fix: add metadata.version to release-please extra-files - #143

Merged
Jacob (JacobPEvans-personal) merged 1 commit into
mainfrom
feature/fix-metadata-version
Mar 18, 2026
Merged

Jacob (JacobPEvans-personal) merged 1 commit into
mainfrom
feature/fix-metadata-version

Conversation

@JacobPEvans-personal

@JacobPEvans-personal Jacob (JacobPEvans-personal) commented Mar 18, 2026 •

Copy link
Copy Markdown
Member

PR #143: Fix Metadata Version Tracking in Release-Please

Summary

  • Adds $.metadata.version jsonpath entry to release-please-config.json extra-files
  • Ensures top-level marketplace metadata version syncs with individual plugin versions during releases

Changes

File modified: release-please-config.json

Added a new extra-files entry in the release-please configuration to track $.metadata.version in
.claude-plugin/marketplace.json. This ensures that when release-please bumps plugin versions during
releases, the top-level metadata version field is also updated automatically, maintaining consistency
across the marketplace index.

Previously, only $.plugins[*].version was being tracked, which meant the metadata version field
could drift out of sync with the actual plugin versions.

Test Plan

  • Verify the updated release-please-config.json has valid JSON syntax
  • Run a test release to confirm both $.plugins[*].version and $.metadata.version are bumped
    in lockstep
  • Check that the marketplace.json metadata remains consistent with plugin versions after release

Related Issues

Related: #142

Adds $.metadata.version jsonpath entry so release-please also updates
the top-level marketplace metadata version alongside individual plugin
versions. Caught by Gemini and Copilot review.

(claude)
Copilot AI review requested due to automatic review settings March 18, 2026 15:18
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a version synchronization discrepancy within the marketplace metadata. By updating the release-please configuration, the system will now automatically manage and update the metadata.version field in the marketplace JSON file, aligning it with plugin versions. This change addresses an issue previously identified by automated code review tools, ensuring consistent versioning across the project's components.

Highlights

  • Release Configuration Update: Added a new jsonpath entry for $.metadata.version to the release-please-config.json file. This ensures that the top-level marketplace metadata version is automatically kept in sync with plugin versions during releases.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment Gemini (@gemini-code-assist) Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on Gemini (@gemini-code-assist) comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the release automation configuration so the repository’s top-level marketplace metadata version is kept in sync with the plugin versions during release-please runs.

Changes:

  • Adds an additional extra-files JSONPath entry to update .claude-plugin/marketplace.json at $.metadata.version.
  • Keeps the existing $.plugins[*].version update behavior intact.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds configuration to update the metadata version during release. My review includes a suggestion to make the release-please-config.json more concise by combining the two update rules for the same file into a single entry, leveraging the tool's support for multiple jsonpaths.

Comment thread release-please-config.json Resolved
@JacobPEvans-personal
Jacob (JacobPEvans-personal) merged commit ee87c76 into main Mar 18, 2026
9 checks passed
@JacobPEvans-personal
Jacob (JacobPEvans-personal) deleted the feature/fix-metadata-version branch March 18, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants