Repository navigation
fix: add metadata.version to release-please extra-files - #143
Conversation
Adds $.metadata.version jsonpath entry so release-please also updates the top-level marketplace metadata version alongside individual plugin versions. Caught by Gemini and Copilot review. (claude)
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a version synchronization discrepancy within the marketplace metadata. By updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on Gemini (@gemini-code-assist) comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Pull request overview
Updates the release automation configuration so the repository’s top-level marketplace metadata version is kept in sync with the plugin versions during release-please runs.
Changes:
- Adds an additional
extra-filesJSONPath entry to update.claude-plugin/marketplace.jsonat$.metadata.version. - Keeps the existing
$.plugins[*].versionupdate behavior intact.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
Code Review
This pull request correctly adds configuration to update the metadata version during release. My review includes a suggestion to make the release-please-config.json more concise by combining the two update rules for the same file into a single entry, leveraging the tool's support for multiple jsonpaths.
PR #143: Fix Metadata Version Tracking in Release-Please
Summary
$.metadata.versionjsonpath entry torelease-please-config.jsonextra-filesChanges
File modified:
release-please-config.jsonAdded a new extra-files entry in the release-please configuration to track
$.metadata.versionin.claude-plugin/marketplace.json. This ensures that when release-please bumps plugin versions duringreleases, the top-level metadata version field is also updated automatically, maintaining consistency
across the marketplace index.
Previously, only
$.plugins[*].versionwas being tracked, which meant the metadata version fieldcould drift out of sync with the actual plugin versions.
Test Plan
release-please-config.jsonhas valid JSON syntax$.plugins[*].versionand$.metadata.versionare bumpedin lockstep
Related Issues
Related: #142