Skip to content
This repository was archived by the owner on Sep 2, 2026. It is now read-only.

fix: add always-bump-minor versioning to prevent automated major bumps - #113

Closed
Jacob (JacobPEvans-personal) wants to merge 1 commit into
mainfrom
feature/always-bump-minor
Closed

Jacob (JacobPEvans-personal) wants to merge 1 commit into
mainfrom
feature/always-bump-minor

Conversation

@JacobPEvans-personal

Copy link
Copy Markdown
Member

Summary

  • Adds "versioning": "always-bump-minor" to release-please-config.json — a native release-please setting that prevents automated major version bumps
  • Adds $comment documenting the org-wide policy so the key doesn't get silently removed again
  • Triggered by claude-code-plugins#176 where an accidental v2.0.0 was created after this config was dropped

Test plan

  • Verify release-please workflow still runs on next push to main
  • Confirm no major version bump PR is created

🤖 Generated with Claude Code

Adds "versioning": "always-bump-minor" to release-please config, which
prevents release-please from ever computing a major version bump regardless
of BREAKING CHANGE footers. Major bumps are human-initiated only via
.release-please-manifest.json.

(claude)
Copilot AI review requested due to automatic review settings March 23, 2026 13:41
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a crucial change to the release-please configuration to prevent accidental automated major version bumps. It ensures that the release process defaults to minor version increments and clearly documents this organizational policy within the configuration file itself, thereby safeguarding against unintended breaking changes in releases.

Highlights

  • Release Please Configuration: Added "versioning": "always-bump-minor" to release-please-config.json to prevent automated major version bumps and ensure only minor versions are incremented by default.
  • Policy Documentation: Included a $comment in release-please-config.json to explicitly document the org-wide policy that major version bumps must be human-initiated, preventing accidental removal of this critical setting.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment Gemini (@gemini-code-assist) Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on Gemini (@gemini-code-assist) comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies release-please-config.json to set the versioning strategy to always-bump-minor, which will prevent release-please from automatically creating major version bumps. A comment has also been added to document this as an organizational policy. The change is correct and effectively implements the desired versioning behavior. I have no further feedback.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s release-please configuration to enforce an org-wide “no automated major bumps” policy, aligning automated releases with the intended versioning approach.

Changes:

  • Adds versioning: "always-bump-minor" to prevent release-please from automatically computing major version bumps.
  • Adds a $comment entry documenting the policy to reduce the chance of accidental removal later.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JacobPEvans-personal

Copy link
Copy Markdown
Member Author

Superseded by centralized enforcement in JacobPEvans/.github#123 — the shared workflow now injects versioning: always-bump-minor at runtime via jq, so individual repos don't need this setting (DRY).

@JacobPEvans-personal
Jacob (JacobPEvans-personal) deleted the feature/always-bump-minor branch March 23, 2026 14:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants