Repository navigation
Fix radial shader float uniforms on GNOME 51 - #324
Open
SheriPrime wants to merge 1 commit into
Open
SheriPrime wants to merge 1 commit into
SheriPrime wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening the switcher on GNOME 51 can fail when the radial background shader calls
set_uniform_float(), which is not provided byClutter.ShaderEffect.Set brightness and vignette sharpness through
set_uniform_value()using explicitly typedGObject.TYPE_FLOATvalues. This also keeps integral values such as 0 and 1 correctly typed for GLSL float uniforms.Validation: JavaScript syntax and diff whitespace checks passed. The same uniform-setting implementation was exercised locally on GNOME Shell 51.1 in an isolated headless session: effects initialized and the switcher was created with three test windows without shader or JavaScript errors. The complete current upstream tree was not runtime-tested.