Repository navigation
Fix extensions.gnome.org review rejection on GNOME 51 - #325
Closed
mohammaddimanpodu wants to merge 1 commit into
Closed
mohammaddimanpodu wants to merge 1 commit into
mohammaddimanpodu wants to merge 1 commit into
Conversation
Reviewer (JustPerfection) rejected v90 with 4 findings, plus Shexli warnings on the same submission. This addresses all of them: - manager.js: remove the 1s unminimize-timeout when the window actor is destroyed, not only on map/timeout (EGO Review Guidelines: Timeout). - manager.js: load the D-Bus interface XML asynchronously (load_contents_async) instead of Gio.File.load_contents (EGO-X-004). - manager.js: drop blanket try/catch in the D-Bus next/previous/select handlers; guard on switcher existence instead. - preview.js: remove the selective-disable guard in cleanup() (early return on _cleanedUp) so teardown always runs fully. - preview.js: remove unnecessary try/catch around 'this.source = null' and _unbindAll() unbind calls. - swipeTracker.js: disconnect scroll-event signals in destroy() (ScrollGesture, MouseScroll) and null the Gio.Settings refs; also fix TouchpadSwipeGesture.destroy() disconnecting from global.stage when the signal was connected on the actor passed to the constructor. - platform.js: drop the blanket try/catch around GSettings reads. - switcher.js: track hidden-window 'notify::visible' signals with connectObject(this) instead of manual ids + try/catch disconnect; remove an accidental duplicate push of the same actor.
Author
|
Closing — will rework offline. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer JustPerfection rejected v90 (shell-version 51) on 2026-11-04: https://extensions.gnome.org/review/77811
Addresses all four findings plus the Shexli warnings:
Shexli warnings:
Syntax-checked all modules (node --check, ESM) and packed with make build. Only smoke-level verification; would appreciate a runtime test on a GNOME 51 session.