[Drift Audit] Maestro rule doc lists stale test category directories - #9382
Draft
daxmobile wants to merge 1 commit into
Draft
[Drift Audit] Maestro rule doc lists stale test category directories#9382daxmobile wants to merge 1 commit into
daxmobile wants to merge 1 commit into
Conversation
The .maestro directory layout diverged from the categories listed in .cursor/rules/maestro-ui-tests.mdc: three directories were renamed with a _flows suffix, preonboarding was folded into onboarding, and several directories (including unified_input_screen) were never listed. Task/Issue URL: https://app.asana.com/1/137249556945/project/1214901934989258/task/1214933126123976
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: (app.asana.com/redacted)
Description
.cursor/rules/maestro-ui-tests.mdc— the "Types of UI tests" section described a.maestro/layout that no longer exists. The doc is the map agents use to locate and run Maestro suites, so a wrong directory name produces amaestro testcommand that fails.Verified against the
.maestro/tree ondevelop(ee431b8):Directories listed under names that no longer exist — the doc's commands (
maestro test .maestro/sync) do not resolve:ad_click_detectionad_click_detection_flowsads_previewads_preview_flowssyncsync_flowspreonboardinglisted as a top-level category, but no such directory exists. Those tests now live inside.maestro/onboarding/aspreonboarding_returning_user_quick_setup_customize.yamlandpreonboarding_returning_user_quick_setup_start_browsing.yaml. The doc now folds pre-onboarding into theonboardingentry.Directories absent from the list. The most significant is
unified_input_screen:#9367(merged 2026-08-03) turned itsunifiedInputTesttag back on (tags: []→tags: [unifiedInputTest]inunified_input_open_duckai_back_to_ntp.yaml) and un-commented the AI-off omnibar-position combos, making it an active tagged CI suite. An agent reading the doc would conclude input-bar tests live only ininput_screen. Also added, each described from its own flow headers:binary_upload,deeplink,omnibar,performance,privacy_tests_internal,serp.The section keeps its "(non-exhaustive)" framing; only the category list changed. Every entry in the updated list resolves to a directory on disk, and every directory in
.maestro/other thanshared/is now listed. No test files, tags, or code were touched.Note on scope: these are bare backticked names, not paths, so
AiConfigChecker.extractReferencesnever classified them as references (it only treats tokens containing/as paths, or:-prefixed tokens as modules) — this drift was invisible toaiConfigCheckrather than a regression in it.I also re-checked
.cursor/rules/wide-events.mdcagainst the sampling work in#7965/#9346and.cursor/rules/pixel-definitions.mdcagainst#9279. Both still match the code —samplingProbability, theSAMPLED_OUT_FLOW_IDsentinel,FlowStatus,CleanupPolicy, the pixel/POST transport split and its default toggle values, and thePixelDefinitionsnpm scripts all read correctly. No changes needed there.🤖 AI-docs Drift Auditor
Steps to test this PR
for d in $(grep -oP '^-\K[a-z0-9_]+(?=)' .cursor/rules/maestro-ui-tests.mdc); do [ -d ".maestro/$d" ] || echo "MISSING: $d"; done— prints nothing.for d in .maestro/*/; do n=$(basename "$d"); [ "$n" = shared ] && continue; grep -q "^- \$n`" .cursor/rules/maestro-ui-tests.mdc || echo "UNLISTED: $n"; done` — prints nothing..maestro/unified_input_screen/carries theunifiedInputTesttag, and that pre-onboarding flows are thepreonboarding_*.yamlfiles inside.maestro/onboarding/.UI changes
Note
🔒 Integrity filter blocked 7 items
The following items were blocked because they don't meet the GitHub integrity level.
search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".To allow these resources, lower
min-integrityin your GitHub frontmatter: