Contextual/NativeInput: Add unifiedInputSurface for voice chat and voice search clicks - #9383
Open
karlenDimla wants to merge 2 commits into
Open
Contextual/NativeInput: Add unifiedInputSurface for voice chat and voice search clicks#9383karlenDimla wants to merge 2 commits into
karlenDimla wants to merge 2 commits into
Conversation
Fire a dedicated m_aichat_unified_input_voice_search_tapped count/daily pixel when the in-field microphone is tapped, distinct from the voice chat pixel fired by the voice-chat chip. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Send the surface (address_bar / duck_ai / contextual_chat) with the m_aichat_unified_input_voice_tapped and m_aichat_unified_input_voice_search_tapped pixels, derived from the native input widget's current input context. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
|
Privacy Review task: https://app.asana.com/0/69071770703008/1217162363528016 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/task/1217108456740157?focus=true
Tech Design URL (if applicable):
API Proposals URL(s) (if applicable):
Description
Steps to test this PR
Filter
pixel sent: m_aichat_unified_input_voice_on your logcatPixel sent: m_aichat_unified_input_voice_search_tapped_count with params: {surface=address_bar} {}Pixel sent: m_aichat_unified_input_voice_tapped_count with params: {surface= address_bar} {}Pixel sent: m_aichat_unified_input_voice_search_tapped_count with params: {surface=contextual_chat} {}Pixel sent: m_aichat_unified_input_voice_tapped_count with params: {surface= contextual_chat} {}Note
Low Risk
Telemetry-only changes to pixel definitions and firing paths; no auth, data handling, or core user flows modified.
Overview
Unified Input analytics now distinguish voice chat (bottom-row button) from in-field microphone taps, and both include
unifiedInputSurfaceso events can be broken down by address bar, Duck.ai tab, or contextual sheet.Voice chat pixels (
m_aichat_unified_input_voice_tapped_*) gain theunifiedInputSurfaceparameter and updated descriptions;fireVoiceTappednow requires aDuckChatPixelSurfaceand sendssurfaceviasurfaceParams.New voice search count/daily pixels (
m_aichat_unified_input_voice_search_tapped_*) track in-field mic taps when the Duck.ai/chat tab is selected.NativeInputModeWidgetroutes those mic taps tofireVoiceSearchTappedinstead offireVoiceTapped(voice chat button still uses voice tapped).Tests cover surface parameters and the new voice-search firing path.
Reviewed by Cursor Bugbot for commit fba1b76. Bugbot is set up for automated code reviews on this repo. Configure here.