Repository navigation
sysmon: split background from style and polish the widget layouts - #4335
Merged
Merged
Conversation
Feedback on the new desktop system monitor widget: the Tiles background and the inner grouping of a layout did almost the same thing, bars of one metric couldn't be told apart, and a few layouts misaligned. Background now only picks the outer surface (Card or None) and Style picks the grouping per layout: Bars get Brackets or Tiles with equal bars and a marker per value, List gets Rows or Tiles (one card per metric). A saved Tiles background maps to None with the Tiles style and is written back on the next settings change. Opacity only shows when a surface uses it. Tiles in one row line up, short Meter and Ring tiles show extras beside the name, four or more tiles avoid a lone last tile, shortened percent values keep their sign, and device titles stay on one line and use the type name unless two devices of that type are shown. The metric editor picks the main value in its own row instead of a star on the first chip, and List drops the Style row that had no effect. Settings: button rows in one card fold together, and folded buttons sit at the trailing edge like inline ones.
Contributor
Claude reviewNo issues found. Checked: the legacy Tiles background upgrade and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #4321 because Stumb told me all my designs suck 😮
The background and the style overlapped: a Tiles background and the inner tiles of a layout did almost the same thing. Now Background only picks the outer surface (Card or None), and Style picks how the metrics are grouped inside it, see screenshots below for examples.
Opacity setting is now only shown when something uses it.
Other fixes:
The settings change two things for every page: when one button row in a card has to move its buttons below the label, all button rows in that card do, and those buttons now sit on the right like the ones next to the label instead of centered.
Behavior changes
Both only affect widgets set up since #4321:
Type of change
Related issues
Screenshots / video
Checklist
I18n.tr()with translator context, reusing existing terms where possiblemake fmt, added/updated tests,make testpasses, andgo mod tidyis cleanmake lint-qmlwith no new warnings