Skip to content

sysmon: split background from style and polish the widget layouts - #4335

Merged
bbedward merged 1 commit into
duxlabs-dev:masterfrom
Conava:sysmon-widget-feedback
Nov 19, 2026
Merged

bbedward merged 1 commit into
duxlabs-dev:masterfrom
Conava:sysmon-widget-feedback

Conversation

@Conava

@Conava Conava commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Description

Follow-up to #4321 because Stumb told me all my designs suck 😮

The background and the style overlapped: a Tiles background and the inner tiles of a layout did almost the same thing. Now Background only picks the outer surface (Card or None), and Style picks how the metrics are grouped inside it, see screenshots below for examples.

Opacity setting is now only shown when something uses it.

Other fixes:

  • Tiles in one row line up, also when only some of them show extra values, and short Meter and Ring tiles show their extra values next to the name instead of hiding them.
  • Four or more tiles no longer leave a single tile alone in the last row (2+2 instead of 3+1).
  • Percent values keep their "%" when they are shortened (VRAM showed "22" instead of "22%").
  • A GPU tile is titled "GPU" unless two GPUs are shown, and names no longer wrap to a second line.
  • The main value of a metric is picked in its own "Main value" row instead of a star on the first value chip.
  • The Style row is gone from the List layout, it didn't change anything there.

The settings change two things for every page: when one button row in a card has to move its buttons below the label, all button rows in that card do, and those buttons now sit on the right like the ones next to the label instead of centered.

Behavior changes

Both only affect widgets set up since #4321:

  • A saved Tiles background becomes None with the Tiles style, or Card for the Graphs layout.
  • The Tiles layout on None now paints the tiles with the widget's opacity. Opacity 0 gives the old look.
  • List with the Meter or Ring style shows plain rows.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that changes existing behavior)
  • Refactor / internal cleanup
  • Documentation
  • Other

Related issues

Screenshots / video

screenshot_2026-11-19_17-02-44 screenshot_2026-11-19_17-02-51 screenshot_2026-11-19_17-03-21 screenshot_2026-11-19_17-03-23

Checklist

  • My code follows the conventions in CONTRIBUTING.md
  • I have tested my changes locally
  • New user-facing strings are wrapped in I18n.tr() with translator context, reusing existing terms where possible
  • Go changes: ran make fmt, added/updated tests, make test passes, and go mod tidy is clean
  • QML changes: ran make lint-qml with no new warnings
  • I have opened a corresponding pull request in dux-docs to document any new behaviors: https://github.com/duxlabs-dev/dux-docs

Feedback on the new desktop system monitor widget: the Tiles background
and the inner grouping of a layout did almost the same thing, bars of
one metric couldn't be told apart, and a few layouts misaligned.

Background now only picks the outer surface (Card or None) and Style
picks the grouping per layout: Bars get Brackets or Tiles with equal
bars and a marker per value, List gets Rows or Tiles (one card per
metric). A saved Tiles background maps to None with the Tiles style and
is written back on the next settings change. Opacity only shows when a
surface uses it.

Tiles in one row line up, short Meter and Ring tiles show extras beside
the name, four or more tiles avoid a lone last tile, shortened percent
values keep their sign, and device titles stay on one line and use the
type name unless two devices of that type are shown. The metric editor
picks the main value in its own row instead of a star on the first chip,
and List drops the Style row that had no effect.

Settings: button rows in one card fold together, and folded buttons sit
at the trailing edge like inline ones.
@github-actions github-actions Bot added feature fix ui Quickshell UI under quickshell/ labels Nov 19, 2026
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Claude review

No issues found.

Checked: the legacy Tiles background upgrade and configFixups write path (every settings write goes through updateConfig), opacity visibility via usesOpacity, the panel/tile color split in MonitorContent, the MonitorBars rewrite and the multi-column bars plan, the MonitorListCard and MonitorTile extras alignment, ring/meter binding dependencies (no loops), RTL bracket and button placement, group-wide button folding in SettingsGroup, the Main value row and value ordering in SettingsMetricFields, lone-tile avoidance in Layout.js, short % formatting, GPU naming in SysmonSource, i18n contexts, deprecated shims, tokens and idle cost (no new timers or processes). Model: claude-opus-5-5.

@bbedward
bbedward merged commit 819b0e8 into duxlabs-dev:master Nov 19, 2026
5 checks passed
@Conava
Conava deleted the sysmon-widget-feedback branch November 19, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature fix ui Quickshell UI under quickshell/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants