Skip to content

Fix blocking I/O #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ic-dev21 merged 1 commit into from
Oct 12, 2026
Merged

Fix blocking I/O #467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions pyhilo/util/state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,15 @@ def _write_state(state_yaml: str, state: dict[str, Any] | StateDict) -> None:
os.replace(tmp_path, state_yaml)


async def _async_write_state(
state_yaml: str, state: dict[str, Any] | StateDict
) -> None:
"""Run _write_state in a worker thread so it doesn't block the event loop."""
await asyncio.get_running_loop().run_in_executor(
None, _write_state, state_yaml, state
)


async def get_state(state_yaml: str, _already_locked: bool = False) -> StateDict:
"""Read in state yaml.

Expand Down Expand Up @@ -143,10 +152,10 @@ async def get_state(state_yaml: str, _already_locked: bool = False) -> StateDict
)
defaults = _get_defaults(StateDict)
if _already_locked:
_write_state(state_yaml, defaults)
await _async_write_state(state_yaml, defaults)
else:
async with lock:
_write_state(state_yaml, defaults)
await _async_write_state(state_yaml, defaults)
return defaults

return state_yaml_payload
Expand All @@ -159,10 +168,10 @@ async def get_state(state_yaml: str, _already_locked: bool = False) -> StateDict
)
defaults = _get_defaults(StateDict)
if _already_locked:
_write_state(state_yaml, defaults)
await _async_write_state(state_yaml, defaults)
else:
async with lock:
_write_state(state_yaml, defaults)
await _async_write_state(state_yaml, defaults)
return defaults


Expand All @@ -186,7 +195,4 @@ async def set_state(
merged_state: dict[str, Any] = {key: {**current_state.get(key, {}), **state}} # type: ignore[dict-item]
new_state: dict[str, Any] = {**current_state, **merged_state}
LOG.debug("Saving state to yaml file")
# TODO: Use asyncio.get_running_loop() and run_in_executor to write
# to the file in a non blocking manner. Currently, yaml.dump is
# synchronous on the main event loop.
_write_state(state_yaml, new_state)
await _async_write_state(state_yaml, new_state)
Loading