Refresh build - #1429
Conversation
|
Really 9a9f0aa is the only change I care about 😆 |
77adf11 to
2004b37
Compare
e566462 to
ed14167
Compare
thisac
left a comment
thisac
left a comment
There was a problem hiding this comment.
LGTM overall. Thanks for this @arcondello!
| "reno==4.1.0", # latest as of July 2026 | ||
| ] | ||
| dev = [ | ||
| "oldest-supported-numpy; python_version < '3.13'", |
There was a problem hiding this comment.
Do we not want to make the move to numpy>2?
| ] | ||
| requires-python = ">=3.10" | ||
| dependencies = [ | ||
| "numpy>=1.17.3", # oldest supported NumPy on Python 3.8 |
There was a problem hiding this comment.
Seems like a good time to bump this, no?
There was a problem hiding this comment.
I was trying to minimize changes. Can change NumPy in another PR.
| foreach path : [ | ||
| 'dimod/binary/cybqm/cybqm_float32.pyx', | ||
| 'dimod/binary/cybqm/cybqm_float64.pyx', | ||
| 'dimod/constrained/cyconstrained.pyx', | ||
| 'dimod/constrained/cyexpression.pyx', | ||
| 'dimod/cyqmbase/cyqmbase_float32.pyx', | ||
| 'dimod/cyqmbase/cyqmbase_float64.pyx', | ||
| 'dimod/discrete/cydiscrete_quadratic_model.pyx', | ||
| 'dimod/quadratic/cyqm/cyqm_float32.pyx', | ||
| 'dimod/quadratic/cyqm/cyqm_float64.pyx', | ||
| 'dimod/cyutilities.pyx', | ||
| 'dimod/cyvariables.pyx', | ||
| ] |
| # meson-managed subprojects | ||
| subprojects/* | ||
| !subprojects/*.wrap |
There was a problem hiding this comment.
Ah, so this is instead of using submodules (for Catch2 in this case)?
There was a problem hiding this comment.
Yes. Includes all of the build etc in a nice way
| python -m pip install twine | ||
| twine upload -u "$PYPI_USERNAME" -p "$PYPI_PASSWORD" --skip-existing ./dist/* | ||
|
|
||
| test-airspeed-velocity: |
There was a problem hiding this comment.
Probably reasonable, but any motivation behind removing all benchmarks?
There was a problem hiding this comment.
Ancient, unused, and a maintenance headache.
| To run the Python tests, first install the package using an editable install | ||
| as described above. The tests can then be run with | ||
| `unittest <https://docs.python.org/3/library/unittest.html>`_. | ||
|
|
There was a problem hiding this comment.
Could mention that pip install --group tests is additionally required to run the tests.
randomir
left a comment
randomir
left a comment
There was a problem hiding this comment.
This is a nice refresh indeed!
Should we drop numpy<2 as part of this pr, or a follow-up?
3 participants
We can add limited API support in a followup.
AI Generation Disclosure
No AI used.