Repository navigation
Conversation
nnastonen
force-pushed
the
SDSTOR-26141_bitmap_alloc_reset_cp_flush_race
branch
4 times, most recently
from
October 19, 2026 12:05
d244810 to
868a80a
Compare
nnastonen
requested review from
JacksonYao287,
raakella1 and
shosseinimotlagh
October 19, 2026 12:07
nnastonen
force-pushed
the
SDSTOR-26141_bitmap_alloc_reset_cp_flush_race
branch
2 times, most recently
from
October 19, 2026 17:02
a27a146 to
d218571
Compare
nnastonen
force-pushed
the
SDSTOR-26141_bitmap_alloc_reset_cp_flush_race
branch
from
October 27, 2026 22:40
d218571 to
dc2b243
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/v8.x #939 +/- ##
===========================================
Coverage ? 49.12%
===========================================
Files ? 112
Lines ? 12797
Branches ? 6068
===========================================
Hits ? 6287
Misses ? 2473
Partials ? 4037 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a chunk is reset (for example when HomeBlocks releases a destroyed volume's chunks), reset_block_allocator() deletes the chunk's bitmap meta blk and replaces the allocator with a new one. A CP flush running at the same time can still hold the old allocator and flush it afterwards. Depending on timing, one of two things happens:
Fix
Make BitmapBlkAllocator::reset() and cp_flush() mutually exclusive, and stop flushing an allocator once it has been reset.
SDSTOR-26141