Repository navigation
Mark end regions by blank gaps - #51
Merged
Merged
Conversation
Scalafmt is 3.11.5. A long for with no blank line no longer picks up an end marker. Fors named only to avoid that marker are expressions again.
The other repos already set maxColumn = 120. Marklit was on the scalafmt default of 80.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scalafmt is 3.11.5. End markers now follow blank gaps, which is scalafmt's implementation of scalameta/scalafmt#5064 (an end marker belongs on a region that contains a blank line, not on a region that is merely long).
The old line-count keys are not set.
Inlined two single-use effect fors in
DocumentProcessorLivethat were named only so a longforwould not pick upend for:processBlockChecked:val effect = for ... yield ...theneffect.catchAllis now(for ... yield ...).catchAllprocessSharedBlock: the same shape insideZIO.foreachsbt-scalafmt2.6.2 already runs 3.11.5, so the plugin was not bumped.Checked:
sbt --server --batch 'scalafmtCheckAll; compile'passed. The control end markers that remain (end foronMarklitCli.runMarklit,end ifonprocessBlockCheckedandMarkdownRenderer.renderCodeBlockMerged,end matchonScopeManagerLive.resolveInternal) close regions that contain a blank line. Scalafmt droppedend afterBuildinBuildSitebecause that method body has no blank line.