Repository navigation
Mark end regions by blank gaps - #32
Merged
Merged
Conversation
Scalafmt is 3.11.5. A long for with no blank line no longer picks up an end marker. Fors named only to avoid that marker are expressions again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The line-count rule was inserting
end foron long comprehensions. End markers now follow blank gaps, which is scalafmt's implementation of scalameta/scalafmt#5064:rewrite.scala3.endMarker.insert.blankGaps.min = 1rewrite.scala3.endMarker.remove.blankGaps.max = 0Scalafmt moved from 3.7.15 to 3.11.5. sbt-scalafmt 2.6.2 accepted that release, so the plugin was left alone. The version jump also changed alignment and dropped end markers on regions with no blank line. A region that contains a blank line still closes with
end(end margin,end KeyframeSelector,end Simple,end RenderArgComponent,end LazyInitComponent, and the existingend extension).No
forwas bound to a val only to dodgeend for, so none were inlined.todo.Main.run,PreactileSpec.checkAfter, and the parenthesized E2E comprehensions inTodoDemoSpecandEmbedHostSpecwere already expressions.scalafmtCheckAllpassed aftercleanFull.compilebuilt core, preactileConduit, docsClient, example, and embed.Test / compilebuilt the changed test sources in core, preactileConduit, and docs.