Skip to content

PLAT-685-allow batch approvals - #75

Open
AlpBilgin wants to merge 3 commits into
masterfrom
PLAT-685-batch-confirm
Open

AlpBilgin wants to merge 3 commits into
masterfrom
PLAT-685-batch-confirm

Conversation

@AlpBilgin

Copy link
Copy Markdown

https://easybill.atlassian.net/browse/PLAT-685

this PR contains the following changes

  • Proposed grants will be textually listed in blocks
    • if more than one user is added there will be a block per user.
    • if the operator can't grant requested accesses, they will be listed in seperate batches
  • User will be prompted to bulk accept, to bulk reject, or to opt for individual approval.
  • checking static YES: AtomicBool = AtomicBool::new(false); and VAULT_FORCE_YES= "1" are packed into a helper function for better organisation and reuse.

Comment thread src/ui/question.rs
Comment on lines +8 to +10
All,
None,
Each,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
All,
None,
Each,
None,
Each,
All,

Please also add doc comments to the enum itself and it's values.

Comment thread src/ui/question.rs
}
}

pub fn confirm(question: &str) -> bool {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add documentation comments for all public items you touched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants