Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root resolution, tidy import repairs and migration previously shared mutable resolver and transaction state. Make ownership explicit inside the existing packages: graph resolution returns owned checked evidence, tidy uses focused input/planning/validation units, and read-only file observations are separate from staged writes.
Migration now groups local/Git selection proofs and exposes preflight, authorized dependency verification and final output stages. One candidate operation updates preview and staged bytes/modes together. Named Git migration requests make whole-namespace, retained-root and explicit-root proof intent readable without changing public roots semantics.
The source behavior, CLI/configuration, Go 1.26.6, dependencies and lock/cache formats are preserved. Add three ownership regressions demonstrated red before implementation: reused provider inspection buffers, mutation of returned checked views, and mutation of captured observation bytes.
Validation:
265fb529.-race(102.867s), including SDK compilation, migration, import repair, cold/frozen replay and breaking controls.Direct state coupling audit: tidy resolver-type references 3→0, resolver-map reads 3→0, transaction storage access outside its implementation 6→0, migration Plan staged-change access 5→0. These are direct reference counts, not a general complexity score.
Stacked on external roots and tidy implementation #236 so reviewers see only this refactor. No merge or release tag is included.