381 apitest hygiene#384
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #384 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 42 42
Lines 3578 3573 -5
=======================================
+ Misses 3578 3573 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several improvements and fixes across the codebase, primarily focused on correcting a misspelled method name, improving code clarity and maintainability, and refining documentation and type annotations. The most significant change is the consistent renaming of the
reflectity_profilemethod toreflectivity_profilethroughout the code and documentation, which resolves a typo and improves code readability. Additional changes include improvements to material handling inProject, better type handling and documentation, and minor code cleanups.Method Renaming and Consistency
reflectity_profiletoreflectivity_profileincalculator_base.pyand updated all references throughout the codebase and tutorials to use the correct spelling. This change ensures consistency and prevents confusion or errors due to the previous typo.Project Material Handling Improvements
Projectby introducing a helper method_get_or_add_material_index, reducing code duplication and improving maintainability. The methodsget_index_air,get_index_si,get_index_sio2, andget_index_d2onow use this helper.Project: removed a straypassstatement and improved the way the minimizer is serialized to avoid unwanted side effects.Type and Interface Improvements
ResolutionFunctionbase class to inherit fromABC(Abstract Base Class), clarifying its intended use as an interface.add_assembliesmethod inModelto accept a variable number ofBaseAssemblyarguments directly, rather than requiring a list, making the API more Pythonic and user-friendly.Limits Handling and Documentation
_apply_percentage_limitsinlimits.pyto correctly set bounds for negative parameter values and clarified the docstring. This prevents incorrect bounds when parameter values are negative.Minor Cleanups and Documentation
_flatten_listfunction fromfitting.pyto reduce dead code.CONTRIBUTING.mdandmkdocs.yml.