Retry flaky connections - #361
Closed
SimonSchwendele wants to merge 5 commits into
Closed
SimonSchwendele wants to merge 5 commits into
SimonSchwendele wants to merge 5 commits into
Conversation
SimonSchwendele
commented
Sep 3, 2026
ebourg
reviewed
Sep 3, 2026
…s connection timeout
ebourg
reviewed
Sep 4, 2026
| wait = getBackoffDelayMs(attempt); | ||
| } | ||
| log.fine(String.format("HTTP error %d from %s, retrying in %d ms (attempt %d of %d)", responseCode, url, wait, attempt, retries)); | ||
| conn.disconnect(); |
Owner
There was a problem hiding this comment.
disconnect() is not necessary here, if there is a keep-alive the connection can be reused for the next attempt. Java will disconnect automatically afterward.
Contributor
Author
There was a problem hiding this comment.
sorry felt like it'd be more clean that way.
I'll alter that when I am done with work
Owner
|
Thank you for the PR. Do you think you could add some tests to RESTClientTest ? |
Contributor
Author
Sure no problem I'll do that after work. |
Owner
|
PR merged with a few cosmetic changes, thank you for the help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using Azure Artifact Signing (azure trusted signing) you're currently ewxperiencing degarded performance.
The api responds slower with each file until it jsign eventually exits.
Eventually we reach
AuthenticodeSignedDataGenerator.getSignerInfowhere where azts dies with a 500 that stops the remaining signatures to be done.Our action crashes like this (sorry for the screenshot, our logs expire pretty fast)
This extends the currently implemented retry loop to retry on errors as well not just on timeouts.
I assume that the remotes would rather send 4xx responses when issues arise with the files or this cli.