Conversation
Owner
|
Thank you for the PR. If the goal is to break on signatures rejected by Windows, then maybe this verification should be implemented as a new rule for the SignatureVerifier class. Otherwise it cripples the API and makes it impossible to read the signature from the file. |
Author
|
makes sense, the throw in getCertificateTable was too blunt. moved it into a CertificateTableRule in SignatureVerifier so the signature is still readable and only the verification fails when the certificate table declares more bytes than the signature entry uses. getCertificateTable stays as it was, and PEFile just exposes getCertificateTableTrailingBytes() for the rule to consult. pushed the change with the tests updated to match. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PE certificate table accepts data smuggled past the signature
the digest excludes the whole certificate table region declared by the data directory, but nothing verifies that the region only holds the signature, so appending bytes and enlarging the certificate table's directory size leaves the digest unchanged and the signature still verifies (CVE-2013-3900 shape). getCertificateTable now rejects a non-EFI table whose declared size runs past the 8-byte-aligned signature entry.