Skip to content

Repair release checks, readiness deadlines, and dependency policy - #25

Draft
echoomegaprime wants to merge 7 commits into
agent/certforge-security-release-20260924from
agent/certforge-readiness-20261003
Draft

echoomegaprime wants to merge 7 commits into
agent/certforge-security-release-20260924from
agent/certforge-readiness-20261003

Conversation

@echoomegaprime

@echoomegaprime echoomegaprime commented Oct 3, 2026 •

Copy link
Copy Markdown
Owner

Objective

Staging, production, and rollback readiness polling could stall inside curl after PR24 increased the polling window. This integrates main and the PR20 repair into the PR23 security candidate, validates the timeout before deployment side effects, and bounds each HTTP request by the remaining elapsed-time budget.

The release policy required authentic CI and CodeQL checks, but the existing job was named test and no CodeQL workflow existed. The substantive validation job now publishes CI; a real Python CodeQL workflow extracts, analyzes, uploads, and processes results. Both workflows check out and assert the exact candidate SHA. Evidence artifacts and CodeQL analysis carry that identity. Official Actions use supported v7/v4 runtimes on the tested Ubuntu 24.04 runner.

Package deployments now require cryptography>=50.0.0, matching the patched image dependency. The regression test remains separate from the stdlib-only certification journey.

Stacked on #23, whose head and existing non-draft review state are unchanged. This PR remains draft.

Evidence

  • Final head: 424fc76fa09d9a83fcbe0d2ec12dc62ef97859c9.
  • CI run 37128321404: success, exact candidate checkout, 704 tests passed, 80.11% coverage. P1 verification, P6 acceptance (12/12), and P7 acceptance passed.
  • CodeQL run 37128321535: success, exact candidate analysis, 43 rules, zero findings. SARIF upload and processing completed; authentic GitHub Actions and GitHub Advanced Security checks both succeeded.
  • Verification artifact is named for the full candidate SHA.
  • Local combined suite before the additional package-policy test: 700 passed, 3 Windows skips. Final dependency/readiness/attestation checks: 57 passed; final test relocation: 7 passed.
  • python -S scripts/certforge_journey.py: 18 passed without third-party stubs. Built wheel metadata requires cryptography>=50.0.0.
  • Bash syntax, actionlint, diff validation, changed-file gitleaks, and independent reviews passed. Fresh build preflight passed 25/25 on this head.
  • Negative cases include malformed/zero/negative/overflowing timeouts, slow cold start, stalled probes, exhausted deadlines, immediate health, all three callers, and vulnerable package versions.

Security and release impact

  • No secrets, private evidence, customer data, or personal information are included.
  • Verdict behavior remains deterministic and fail closed.
  • Public contract and documentation changes are included where applicable.
  • Staging-first deployment and rollback implications are documented.
  • Unrelated repository history and license boundaries are preserved.

Listener ownership checks, signed readiness, failure-log retention, rollback gates, and intentionally vulnerable acceptance fixtures remain intact. The HTTP polling deadline excludes existing service-manager/listener subprocesses and the separate bounded diagnostic probe.

The earlier GitHub CLI workflow-scope denial is resolved through explicit owner approval and GitHub's official consent flow. The prepared workflow changes are now published and verified. No alternate credential route was used for the denied action.

Remaining gates

Neither new candidate head currently has a Release Sentinel or CertForge check. Passing CI and CodeQL does not establish signed production readiness. Current production SHA, independently signed production E2E, and new exact-SHA CertForge/GitHub App certification remain unverified. The Forge connector still requires reauthentication; that boundary was not bypassed.

PR24 reports historical successful staging/production smoke for d8ad9fd, superseding PR23's older 'not deployed' statement. That evidence does not certify this candidate. Main's observed branch-protection/ruleset enforcement gap was not changed.

No merge, deployment, production smoke, production rollback, signing, or repository security-setting change was performed.

echoomegaprime and others added 6 commits September 25, 2026 17:53
The staging boot, rollback-restore and production health waits each polled
/healthz for only 20s (40 x 0.5s). A cold uvicorn boot on a loaded FORGE
exceeds that: it aborted the d8ad9fd security release at staging, and the
same budget can report a healthy rollback as failed or roll back a good
production release.

- CERTFORGE_READY_TIMEOUT_S (default 90) drives all three waits; a healthy
  service still returns on the first successful probe.
- On a staging readiness failure, print the /healthz probe result and keep
  service.log under $STATE_ROOT/deploy-logs/ before the EXIT trap removes
  the scratch directory.


Claude-Session: https://claude.ai/code/session_0152mN1wMwj9vE2YmV2xZF4F

Co-authored-by: echoomegaprime <314902331+echoomegaprime@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@echoomegaprime echoomegaprime changed the title Bound readiness probes and reconcile the security release stack Bound readiness and enforce patched package dependencies Oct 3, 2026
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@echoomegaprime echoomegaprime changed the title Bound readiness and enforce patched package dependencies Repair release checks, readiness deadlines, and dependency policy Oct 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants