Repository navigation
Repair release checks, readiness deadlines, and dependency policy - #25
Draft
echoomegaprime wants to merge 7 commits into
Draft
echoomegaprime wants to merge 7 commits into
echoomegaprime wants to merge 7 commits into
Conversation
The staging boot, rollback-restore and production health waits each polled /healthz for only 20s (40 x 0.5s). A cold uvicorn boot on a loaded FORGE exceeds that: it aborted the d8ad9fd security release at staging, and the same budget can report a healthy rollback as failed or roll back a good production release. - CERTFORGE_READY_TIMEOUT_S (default 90) drives all three waits; a healthy service still returns on the first successful probe. - On a staging readiness failure, print the /healthz probe result and keep service.log under $STATE_ROOT/deploy-logs/ before the EXIT trap removes the scratch directory. Claude-Session: https://claude.ai/code/session_0152mN1wMwj9vE2YmV2xZF4F Co-authored-by: echoomegaprime <314902331+echoomegaprime@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
5 tasks done
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Staging, production, and rollback readiness polling could stall inside curl after PR24 increased the polling window. This integrates main and the PR20 repair into the PR23 security candidate, validates the timeout before deployment side effects, and bounds each HTTP request by the remaining elapsed-time budget.
The release policy required authentic
CIandCodeQLchecks, but the existing job was namedtestand no CodeQL workflow existed. The substantive validation job now publishesCI; a real Python CodeQL workflow extracts, analyzes, uploads, and processes results. Both workflows check out and assert the exact candidate SHA. Evidence artifacts and CodeQL analysis carry that identity. Official Actions use supported v7/v4 runtimes on the tested Ubuntu 24.04 runner.Package deployments now require
cryptography>=50.0.0, matching the patched image dependency. The regression test remains separate from the stdlib-only certification journey.Stacked on #23, whose head and existing non-draft review state are unchanged. This PR remains draft.
Evidence
424fc76fa09d9a83fcbe0d2ec12dc62ef97859c9.python -S scripts/certforge_journey.py: 18 passed without third-party stubs. Built wheel metadata requirescryptography>=50.0.0.Security and release impact
Listener ownership checks, signed readiness, failure-log retention, rollback gates, and intentionally vulnerable acceptance fixtures remain intact. The HTTP polling deadline excludes existing service-manager/listener subprocesses and the separate bounded diagnostic probe.
The earlier GitHub CLI workflow-scope denial is resolved through explicit owner approval and GitHub's official consent flow. The prepared workflow changes are now published and verified. No alternate credential route was used for the denied action.
Remaining gates
Neither new candidate head currently has a Release Sentinel or CertForge check. Passing CI and CodeQL does not establish signed production readiness. Current production SHA, independently signed production E2E, and new exact-SHA CertForge/GitHub App certification remain unverified. The Forge connector still requires reauthentication; that boundary was not bypassed.
PR24 reports historical successful staging/production smoke for
d8ad9fd, superseding PR23's older 'not deployed' statement. That evidence does not certify this candidate. Main's observed branch-protection/ruleset enforcement gap was not changed.No merge, deployment, production smoke, production rollback, signing, or repository security-setting change was performed.