Repository navigation
fix: bind VCDM 2.0 JOSE credentials to their issuer's key - #6141
Merged
paullatzelsperger merged 1 commit intoOct 21, 2026
Merged
paullatzelsperger merged 1 commit into
paullatzelsperger merged 1 commit into
Conversation
Vcdm20JosePresentationVerifier now validates every enveloped credential with a rule that requires its kid to start with "<issuer>#", where the issuer is the credential's issuer property (a string or the id of an object), and its iss claim, if present, to equal that issuer. Enveloped VCDM 1.1 credentials are validated with the dcp-vc rules and IssuerKeyIdValidationRule, as in a VCDM 1.1 presentation. IssuerKeyIdValidationRule compares the kid with the iss literally instead of with an unescaped regular expression, in which the dots of a did:web host name matched any character. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
jimmarino
approved these changes
Oct 21, 2026
wolf4ood
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Vcdm20JosePresentationVerifiervalidates every enveloped VCDM 2.0 credential with a newCredentialIssuerKeyIdValidationRule: thekidmust start with<issuer>#, where the issuer is the credential'sissuerproperty (a string, or theidof an object), and anissclaim, if present, must equal that issuer. Before, only the signature was checked against whatever key thekidnamed.vcclaim) are validated with thedcp-vcrules andIssuerKeyIdValidationRule, like in a VCDM 1.1 JWT presentation.IssuerKeyIdValidationRulecompares thekidwith<iss>#literally instead of with a regular expression built from the unescapediss, and fails if either is missing.Why it does that
A credential in a VCDM 2.0 presentation that named a trusted issuer but was signed with a key of any other resolvable DID was accepted, because nothing tied the signing key to the issuer that
HasValidIssuerlater checks. InIssuerKeyIdValidationRule, the dots of adid:webhost name matched any character, so e.g.did:web:issuer-example.com#key-1was accepted for the issuerdid:web:issuer.example.com. That rule also binds self-issued ID tokens to their issuer.Linked Issue(s)
Closes #6140
🤖 Generated with Claude Code