Repository navigation
feat: make data plane instance ids unique per participant context - #6143
Merged
wolf4ood merged 2 commits intoOct 22, 2026
Merged
Conversation
jimmarino
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Makes
(participantContextId, id)the identity of aDataPlaneInstance, as decided in the follow-up of theper-participant resource identifiers
decision record.
Stores.
participant_context_idisNOT NULL, the primary key is(participant_context_id, id), and the upsertconflicts on that pair. The
participant_context_idindex is dropped from the schema: the primary key covers it.ParticipantResourceKey.SPIs (breaking).
DataPlaneInstanceStorefindById(id),deleteById(id),getAll()findById(participantContextId, id),deleteById(participantContextId, id)DataPlaneSelectorServicefindById(id),delete(id),unregister(id),getAll()findById(participantContextId, id),delete(participantContextId, id),unregister(participantContextId, id)save/register,query/searchandselectForkeep their signatures.Callers.
DataPlaneSignalingFlowControllerandDataPlaneTransferAuthorizationFiltertake the participant context of thetransfer process.
GET /v4/dataplanestake the participant context of theSingleParticipantContextSupplier. The listing now returns only the instances of that participant context.is removed: the same id can now be registered by different participant contexts.
Migration. New
README.mdindata-plane-instance-store-sql, with the statements to migrate an existingdatabase. Rows with a NULL participant context must be assigned to one first.
Why it does that
With global ids, the v5 registration revealed the ids used by other participant contexts (409) and allowed squatting
them, and the store and service SPIs could be called without any participant context (M9 follow-up and L3 in #6005).
Further notes
DataPlaneInstanceStoreandDataPlaneSelectorServiceimplementations and for their callers.UPDATE/ALTER TABLEstatements.
the data plane registration, data plane selector and catalog end-to-end tests (in-memory and PostgreSQL).
Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Part of #6005
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.