Repository navigation
fix: add STS client secret rotation and an optional bind host for the STS API - #1232
Merged
paullatzelsperger merged 2 commits intoOct 21, 2026
Conversation
… STS API
- new Identity API endpoint POST /v1/participants/{id}/sts/secret rotates the
STS client secret of a participant context under the same vault alias
- StsAccountService.updateSecret checks the account's participant context,
stores the new secret before switching to it, deletes the old secret only
afterwards and returns the new secret
- optional web.http.sts.host setting binds the STS API to one interface
- document that the STS API must not be publicly reachable
Closes eclipse-edc#1231
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
wolf4ood
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
POST /v1/participants/{participantContextId}/sts/secret, regenerates the STS client secret of a participant context and returns it. It has the same authorization as the API key regeneration endpoint (the participant itself or an admin). The new secret is stored under the existing vault alias, so the vault entry is replaced and no alias or vault policy changes. A participant context without an STS account gets a 404.StsAccountService.updateSecretchecks that the account belongs to the given participant context, stores the new secret before the account is switched to the new alias, deletes the old secret only afterwards (and the new one if the switch fails), and returns the new secret instead of the alias.web.http.sts.host, binds the STS API to one network interface. When it is unset, the STS API listens on all interfaces as before.sts-apinow depends onjetty-coreandjetty-serverfor this.Why it does that
An STS client secret could not be changed after the participant context was created, so a leaked secret stayed valid until an operator overwrote the vault entry manually or deleted the participant context.
updateSecretdeleted the old secret before storing the new one and did not check ownership. The STS API always listened on all network interfaces.Linked Issue(s)
Closes #1231
🤖 Generated with Claude Code