Create a terminal settings default terminal executable setting - because On windows, cmd.exe is being chosen by default and it requires a custom env variable to change it

[nddipiazza-ebay]

Use "Show in" and choose Terminal.

It keeps choosing cmd.exe by default. I cannot seem to get it to stop.

I removed it from everything yet it still uses it?

It seems like this is set here. If a ComSpec environment variable is set, it uses that for the terminal. Otherwise, it seems to use cmd.exe on windows.

So an environment variable is needed to fix the issue. Which means the Terminal configuration dialog options are inadequate with this regard.

Suggested change

Clicking button would show the choose terminal profile dialog, similar to dialog displayed when launching a terminal:

[danthe1st]

It seems like this functionality is already present, just disabled on Windows.

This was already the case when this feature was added in 2015

The shell is then selected here as you noticed already.

[vogella]

It seems like this functionality is already present, just [disabled on Windows]

Do you know why it was disabled on Windows?

[danthe1st]

Do you know why it was disabled on Windows?

No and I am mainly developing (for personal projects and Open Source contributions at least) on a Linux system so I can't test it here. I can maybe try to check on a Windows system with a naive change (but I don't have anything set up for Eclipse development there).

One possible reason could be the different way to get the correct shell between Windows and other systems or maybe there was just no other relevant shell on Windows when that was created.

[danthe1st]

After removing some more checks (ce7c936, there are no functional changes other than removing !Platform.OS_WIN32.equals(Platform.getOS())), it worked for me on Windows with both a different shell and additional arguments.

The main thing I noticed is that the (default) color scheme of the Eclipse terminal doesn't work well with Powershell (parts of the commands are invisible).
Other than that, it seems like passing arguments requires setting a shell but I don't think that's Windows-specific.

I can create a PR if needed but I haven't done extensive testing using most of the possible code paths.

[vogella]

Yes, please provide PR

[danthe1st]

@vogella I now created #2932