Fix handling of DOS device paths in Win32Handler and unify Path handling - #2955
Open
HannesWell wants to merge 1 commit into
Open
HannesWell wants to merge 1 commit into
HannesWell wants to merge 1 commit into
Conversation
The method Win32Handler.toLongWindowsPath() handled file paths incorrectly if they are already DOS device paths to an ordinary file, i.e. started with \\?\, e.g. a path like \\?\C:\User\Foo\bar.txt. In real world scenarios this was probably of little relevance since the Eclipse platform usually does not pass such DOS device paths.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method Win32Handler.toLongWindowsPath() handled file paths incorrectly if they are already DOS device paths to an ordinary file, i.e. started with \?, e.g. a path like \?\C:\User\Foo\bar.txt.
In real world scenarios this was probably of little relevance since the Eclipse platform usually does not pass such DOS device paths.