Skip to content

Move instead of copy when committing a SafeFileOutputStream #2961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vogella merged 1 commit into from
Sep 22, 2026
+8 −2
Merged

Move instead of copy when committing a SafeFileOutputStream #2961

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ...eclipse.core.resources/src/org/eclipse/core/internal/localstore/SafeFileOutputStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
package org.eclipse.core.internal.localstore;

import java.io.*;
import java.nio.file.AtomicMoveNotSupportedException;
import java.nio.file.Files;
import java.nio.file.StandardCopyOption;

Expand Down Expand Up @@ -82,8 +83,13 @@ protected void commit() throws IOException {
if (!temp.exists()) {
return;
}
Files.copy(temp.toPath(), target.toPath(), StandardCopyOption.REPLACE_EXISTING);
temp.delete();
try {
// a rename does not rewrite the bytes and never leaves a partially written target
Files.move(temp.toPath(), target.toPath(), StandardCopyOption.ATOMIC_MOVE);
Comment thread
iloveeclipse marked this conversation as resolved.
} catch (AtomicMoveNotSupportedException e) {
Files.copy(temp.toPath(), target.toPath(), StandardCopyOption.REPLACE_EXISTING);
temp.delete();
}
}

protected void createTempFile(String tempPath) {
Expand Down
Loading