Fix flaky testMouseMoveOpensTheToolbarForTheHoveredDiff - #2963
Merged
tobiasmelcher merged 1 commit intoSep 23, 2026
Merged
tobiasmelcher merged 1 commit into
tobiasmelcher merged 1 commit into
Conversation
…iff flakiness Replace the toolbar.getVisible() assertion with assertNotSame() to verify that the mouse move created a new toolbar composite. The visibility check was sensitive to whether the text widget had been painted (layout-dependent), causing intermittent failures on Java 26. Fixes eclipse-platform#2962
Contributor
Member
|
@tobiasmelcher : the test doesn't fail for me locally neither with nor without change :-) |
Member
|
Feel free to merge if the build will be green. |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The identity assertion conflicts with valid toolbar reuse and remains dependent on prior mouse activity.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Updates a flaky unified-diff toolbar hover test.
Changes:
- Replaces toolbar visibility checking with composite identity checking.
- Captures the toolbar instance before synthetic mouse movement.
| File | Description |
|---|---|
UnifiedDiffManagerTest.java |
Revises the toolbar hover assertion. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tries to fix #2962
The
testMouseMoveOpensTheToolbarForTheHoveredDifftest was checkingtoolbar.getVisible()after a synthetic mouse move. Replace thegetVisible()assertion withassertNotSame(toolbarBefore, toolbar)— this verifies that the mouse move caused a new toolbar composite to be created/installed, which is the real invariant the test should enforce.