Repository navigation
Mass fixes - #18
Merged
Merged
Mass fixes#18
Conversation
- propagatedBuildInputs → dependencies (633 files) - checkInputs → nativeCheckInputs (20 files) - remove redundant doCheck = false (1283 files, already the default) - remove redundant doCheck = true at top level (4 files) - remove redundant __structuredAttrs = true (323 files, already the default) - rev → tag for version-based git references (278 files) - placeholder "out" → $(out) shell output reference (6 files) - format = "pyproject" → pyproject = true (1 file) - fix orphaned blank lines from removed attributes
Convert all 565 packages using `format = "setuptools"` to the preferred `pyproject = true` with explicit `build-system = [ setuptools ]`. For packages that had setuptools in nativeBuildInputs (26), it was moved to build-system. For the remaining 525+, setuptools was added to the function arguments with a `# build-system` comment group.
Convert 4122 packages from `buildPythonPackage rec { ... }` to
`buildPythonPackage (finalAttrs: { ... })`.
- version/pname references updated to use finalAttrs:
- `inherit pname version` → `inherit (finalAttrs) pname version`
- `tag = version` → `tag = finalAttrs.version`
- `${version}` → `${finalAttrs.version}` in string interpolations
- `env.FOO = version` → `env.FOO = finalAttrs.version`
- `self = buildPythonPackage rec` patterns unwrapped with
`self.` → `finalAttrs.finalPackage.`
- `buildPythonPackage.override {...} rec` also converted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do a fix sweep of python packages