Apply item attribute key fix to base_v1_21_4 - #1525
Open
JToTl wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1506. The fix in commit 958fcb0 added the key-aware
setItemAttributeoverload and updated the v26 implementations, butbase_v1_21_4was not updated.base_v1_21_4continued to inheritsetItemAttributefrombase_v1_20_5. The inherited implementation does not useattributeKey; it callscreateAttributeModifierwith the UUID instead. The existing override inbase_v1_21_4then converts this to the constant keymagic:modifier, so multiple modifiers can still receive the same key.This change overrides the key-aware overload in
base_v1_21_4and creates the modifier using the supplied key. When no key is specified, it generates the same default key used by the v26 implementations:modifier_<attribute>_<slot>.The five- and six-argument overloads remain inherited from
base_v1_20_5and delegate to this override.