Skip to content

support for hostname config field#32

Open
mayel wants to merge 1 commit into
elixir-dbvisor:mainfrom
mayel:fix-hostname-and-ready
Open

support for hostname config field#32
mayel wants to merge 1 commit into
elixir-dbvisor:mainfrom
mayel:fix-hostname-and-ready

Conversation

@mayel

@mayel mayel commented Jul 10, 2026

Copy link
Copy Markdown

Hi, this lib looks really interesting, thanks!
Here's a PR for a couples issues I encountered when trying it out.

@Schultzer

Copy link
Copy Markdown
Member

Hey @mayel thanks for this PR, I’m properly not going to merge this as is, as I’m getting ready to commit a bigger refactor of the the pool that addresses the not readiness.

Regardless we do need to address the hostname.

@mayel

mayel commented Jul 10, 2026

Copy link
Copy Markdown
Author

Sounds good! I'll wait for your refactor before proceeding with it then :)

@Schultzer

Copy link
Copy Markdown
Member

Sounds good! I'll wait for your refactor before proceeding with it then :)

Awesome, I just comitted what I've been working on. You might be hitting some subtle bugs that I'm still working on but you should be able to rebase your PR and adjust your changes.

@Schultzer Schultzer force-pushed the main branch 2 times, most recently from 5892e5e to 7c3092a Compare July 11, 2026 20:28
@mayel mayel force-pushed the fix-hostname-and-ready branch from 963ea4d to 2f169a7 Compare July 11, 2026 20:29
@mayel

mayel commented Jul 11, 2026

Copy link
Copy Markdown
Author

I've re-applied the hostname fix, but wasn't properly able to test as compiling :sql as a dependency now fails intermittently with SQL.Application.start/2 is undefined in queries.ex, maybe because use SQL runs ensure_all_started(:sql) at compile time and the compiler enters a race condition?

@Schultzer

Copy link
Copy Markdown
Member

I've re-applied the hostname fix, but wasn't properly able to test as compiling :sql as a dependency now fails intermittently with SQL.Application.start/2 is undefined in queries.ex, maybe because use SQL runs ensure_all_started(:sql) at compile time and the compiler enters a race condition?

Yeah, thats my bad. I fixed that on main.

Also, I think it would be better to move this code into SQL.Pool, since it would be run for each connection in the pool instead of once for the whole pool.

@Schultzer Schultzer changed the title support for hostname config field, and added ready status to fix issue on initial connection support for hostname config field Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants