Skip to content

ci: a draft pull request runs its checks when it is marked ready (green) - #2

Merged
RoozbehBandpey merged 1 commit into
mainfrom
claude/funny-hypatia-0qs96i
Oct 23, 2026
Merged

RoozbehBandpey merged 1 commit into
mainfrom
claude/funny-hypatia-0qs96i

Conversation

@RoozbehBandpey

Copy link
Copy Markdown
Contributor

Summary

ci.yml skips draft pull requests. pull_request's default types (opened, synchronize, reopened) never fire when a draft is marked ready, so a draft marked ready ran no gate until its next push.

  • ci.yml now lists ready_for_review in its pull_request types.
  • scripts/check.py gains draft_trigger_problems: a workflow whose jobs skip drafts must list ready_for_review. Three tests cover it.
  • The CI job id stays gate, and the reusable workflow and its inputs are unchanged.

Architecture: go (2026-10-23).

Linked issue or spec

Minute-saving rules for workflows: drafts start nothing, and a draft marked ready runs once.

Checks

  • task gate passes locally. Result (last lines of output):

    .....................................................                    [100%]
    53 passed in 0.21s
    
  • Added an entry to log/devlog.md (date, what landed, numbers, still open).

  • Tests added or updated for the change.

  • UI changes: not a UI change.

  • Public repositories: the diff contains no secrets, credentials, customer data, internal details or content from private repositories.


Generated by Claude Code

The gate skips drafts, and pull_request's default types never fire on
ready_for_review, so a draft marked ready ran nothing until its next push.
ci.yml lists ready_for_review; check.py refuses a draft-guarded workflow
without it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01V5E9o15BjmsWrwQY3Ajc6S
@RoozbehBandpey
RoozbehBandpey merged commit 36ca67b into main Oct 23, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants