feat(cli): thread Config through the export path - #199
Open
ecalifornica wants to merge 2 commits into
Open
Conversation
|
🔍 Preview deployed: https://8e66b458.toolpath.pages.dev |
ecalifornica
force-pushed
the
robert/config-export
branch
from
August 14, 2026 19:49
afb336f to
f36723d
Compare
ecalifornica
marked this pull request as ready for review
August 14, 2026 20:41
ecalifornica
force-pushed
the
robert/config-export
branch
from
August 18, 2026 20:08
f36723d to
258f10d
Compare
ecalifornica
force-pushed
the
robert/config-export
branch
from
August 24, 2026 15:33
258f10d to
0e8df6d
Compare
ecalifornica
force-pushed
the
robert/config-export
branch
from
August 24, 2026 15:44
0e8df6d to
b4f1ab7
Compare
ecalifornica
force-pushed
the
robert/config-export
branch
from
August 24, 2026 15:52
b4f1ab7 to
c92cf35
Compare
ecalifornica
force-pushed
the
robert/config-export
branch
from
August 24, 2026 15:59
c92cf35 to
b8117e1
Compare
ecalifornica
force-pushed
the
robert/config-export
branch
from
August 25, 2026 18:09
b8117e1 to
47ff69e
Compare
akesling
reviewed
Aug 27, 2026
| path: &TPath, | ||
| harness: Harness, | ||
| cwd: &std::path::Path, | ||
| config: &Config, |
Contributor
There was a problem hiding this comment.
Should we have some projection config type that we build from our general config so we aren't passing all the config info everywhere? This would make clear what is needed by the lower layer.
ecalifornica
force-pushed
the
robert/config-export
branch
from
August 27, 2026 18:08
9983ec1 to
dee3c84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmd_export::run(along with its forwarders incmd_projectandcmd_incept) takes&Config.cmd_resume::project_into_harnesstakes&ProjectionConfig.ProjectionConfigis the subset ofConfigthat builds a provider manager: the harness store roots ($HOMEwith the$USERPROFILEfallback,$XDG_DATA_HOME,$COPILOT_HOME,$APPDATA).Config::projectionbuilds it. Theproviders::*_convofactories take&ProjectionConfig; the other command modules call them withconfig.projection().Each of the 9 export helpers that writes into a harness's on-disk layout takes
&ProjectionConfigand builds itsPathResolverfromproviders::<harness>_convo(config).cmd_resume::run_with_strategyloads aConfigat its call site because resume is threaded by its own PR.The
cmd_exportunit tests inject aConfiginstead of setting$HOME, and drop theTEST_ENV_LOCKguard.Behavior change: on Windows with
$HOMEunset, the pi export paths resolve%USERPROFILE%\.pi\agent\sessions, matching the import and sync paths.Part of #184.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.