core(routing): reconcile against system route state - #148
Draft
tionis wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #97.
Nylon now reads the actual addresses and routes on its interface instead of relying on an in-memory record of previously successful commands.
This means it can recover if another process changes the route table, the OS removes a route, or a command only partially succeeds.
The new
SystemRoutesinterface supports Linux, macOS, and Windows using their existing system networking tools. Reconciliation still adds new entries before removing old ones to avoid unnecessary connectivity interruptions.Kernel-managed connected routes and link-local addresses are left alone.
Before this is upstreamed we should do some cross-platform testing as e.g. powershell might have quite a big overhead.