chore: release - #328
Conversation
|
Thanks for the heads up! I'm on it — taking a look at this |
There was a problem hiding this comment.
Release PR looks correct — approving the change itself. One thing blocks the merge button and it needs a click from you, not an edit here.
⚠️ Merge is blocked on workflow approval, not on this diff
All four workflow runs on this branch were created but are held in action_required (awaiting approval, 0s duration):
| Workflow | Status |
|---|---|
| Continuous integration | action_required |
| Delivery | action_required |
| API diff | action_required |
| PR Title | action_required |
The main: required checks ruleset (id 20607291, active) requires exactly one context: Wire compat. That job lives in .github/workflows/build.yml — inside Continuous integration — so while that run is unapproved the required check never reports at all. The result is mergeStateStatus: BLOCKED with 0 checks on the head sha (e6d9e34), and no amount of waiting clears it.
Fix is one click: Approve and run workflows on the PR's checks tab. This is the same state PR #278 was in — its checks only started at 2026-08-10T12:25Z, long after it was opened on 2026-07-31, then it merged at 13:18Z.
Expect it on every release-plz PR. Note the mechanism precisely, because it is not the usual "a GITHUB_TOKEN push starts no workflows" case: the head branch is in this repo (isCrossRepository: false), the runs were created, and they are sitting behind an approval gate because the PR's author is github-actions[bot], which the gate does not treat as a collaborator. So a permanent fix is either running release-plz-pr under a PAT / app token whose identity is a collaborator, or relaxing the repo's require-approval-for-contributors setting — not just a token swap. I could not read /repos/.../actions/permissions to confirm which setting is in force (403 for my token), so please check that before changing anything.
What I verified on the release content
- Patch bump is right. The only commit on
mainsince tagpg-pkg-v0.6.1isfa4df1b(test: guard the Dockerfile/workspace-member invariant, scope the dev cook, #326). No!in the title, no public-API change —0.6.1 -> 0.6.2is correct, and this repo reads a break off the PR title only, so nothing here should have cut a major. - Changelog placement is right. The generated
[0.6.2]section sits below## [Unreleased]and above## [0.6.1]; no already-released section was edited, and no hand-written bullet is stranded under[Unreleased]. - Lockfile is in sync.
Cargo.lockmovespg-pkgto the same0.6.2. - The publish job exists.
delivery.ymltags the image fromneeds.release-plz-release.outputs.pg_pkg_version, so unlike thecryptify-v0.1.28case this version will not end up as a release with no artifact — worth checking GHCR for the0.6.2tag after merge anyway, since the release and the image push are separate events.
Note: the 0.6.2 image is behaviourally identical to 0.6.1
fa4df1b touched only pg-pkg/tests/dockerfile_workspace_members.rs (new), dev.Dockerfile and CLAUDE.md — nothing under pg-pkg/src/, and not the repo-root Dockerfile that builds the released image. So the changelog line describes a test and a dev-image change, and ghcr.io/encryption4all/postguard:0.6.2 will behave exactly like :0.6.1. Nothing wrong — release-plz generated the entry faithfully from the commit subject — just don't expect the new tag to change anything for a deployment, and no need to hurry the ops pin to it.
One carried-forward nit on pg-pkg/Cargo.toml inline below.
| repository = "https://github.com/encryption4all/postguard" | ||
| name = "pg-pkg" | ||
| version = "0.6.1" | ||
| version = "0.6.2" |
There was a problem hiding this comment.
Pre-existing (also on main, not introduced by this PR), but this bump is where it bites: pg-pkg/src/opts.rs:6-7 hardcodes name = "irmaseal-pkg", version = "0.2", so the binary this release ships still prints irmaseal-pkg 0.2 for --version while the crate moves to 0.6.2 — the pre-rename name and a version frozen nine minor releases back.
That is the crate's only version surface: there is no CARGO_PKG_VERSION anywhere in pg-pkg/src (verified — zero hits), and /health returns no version either. So once delivery tags the image 0.6.2 there is no way to confirm from inside a running container which build is actually deployed.
Fix is version = env!("CARGO_PKG_VERSION") (or clap's derive #[command(version)]) plus dropping the stale irmaseal-pkg name. Worth its own small PR rather than touching this auto-generated one.
|
Reviewed and approved this one — the 0.6.2 patch bump is correct (only commit since 0.6.1 is a One thing needs a human click, not a code change: all 4 workflow runs are stuck in Two non-blocking notes left inline: I also saved a rule so the next release-plz PR gets this diagnosed immediately instead of looking like a CI failure. |
a107289 to
ac3132d
Compare
ac3132d to
16a402e
Compare
16a402e to
aa0fdc0
Compare
🤖 New release
pg-core: 0.6.3 -> 0.6.4 (✓ API compatible changes)pg-pkg: 0.6.1 -> 0.6.2cryptify: 0.1.29 -> 0.1.30pg-cli: 0.3.8 -> 0.3.9Changelog
pg-corepg-pkgcryptifypg-cliThis PR was generated with release-plz.