Expose complete PTY request metadata - #7
Merged
Conversation
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes complete PTY request metadata without allocating or configuring an operating-system PTY.
Pty.TerminalModesand pixel dimensions toWindowpty-reqandwindow-changepayloadsThis reimplements and extends the ideas from gliderlabs/ssh#131 by @elfgzp and gliderlabs/ssh#210 by @aymanbagabas, which credits Maisem Ali and Tailscale#4154. Neither upstream patch was cherry-picked; this version fixes malformed-input, opcode-boundary, map-aliasing, 32-bit conversion, and test-coverage gaps.
Breaking API note for this
v0.xmodule: unkeyedWindowandPtyliterals must use named fields, andPtyis no longer comparable because it contains a map.Verified with the full test suite, race detector, Linux/386 tests, Windows cross-build,
go vet,golangci-lint, and all example modules.