GraalJS Compatibility #156

[rymsha]

Fixes #156.

What

Nashorn maps a property write on a Java host object to its setter (bean.foo = x → setFoo(x)); GraalJS does not — that shorthand went away with nashorn-compat mode (enonic/xp#9236). Every such write throws TypeError: writeMember (foo) ... Unknown identifier: foo at runtime.

This replaces all 38 property writes listed in the issue with the matching setter calls in src/main/resources/lib/text-encoding.js, each verified against its handler class:

Property write	Setter	Handler(s)
bean.stream = …	bean.setStream(…)	Base64 / Base64Url / Base32 / Hex / CharsetEncoding / HashFunction / HmacFunction
bean.text = …	bean.setText(…)	Base64 / Base64Url / Base32 / Hex / CharsetEncoding / UrlEscape / HtmlEscape / XmlEscape
bean.charset = …	bean.setCharset(…)	CharsetEncoding (field is charsetName, setter is setCharset)
bean.key = …	bean.setKey(…)	HmacFunction

setStream takes Object (the Java side converts strings/numbers/booleans), so the stream sites pass the value straight through. setKey is guarded by an explicit key === undefined throw, so it needs no null wrap.

String coercion for setText

One nuance beyond the mechanical setter conversion: Nashorn also coerced number/boolean values to String when writing a String-typed property, so urlEscape(33) → "33" and urlEscape(true) → "true". The plain setText(33) call does not — GraalJS rejects it with "Cannot convert '33' (…) to Java type 'java.lang.String': Invalid or lossy primitive coercion" — which broke the pre-existing testUrlEscapeNumber / testUrlEscapeBool tests.

To preserve that behaviour on both engines, the text setters receive a null-safe String(...):

bean.setText(text == null ? null : String(text));

This is a superset of the __.nullOrValue the issue prescribes — same undefined/null → null handling, plus the coercion Nashorn's property write used to perform. The charset setter keeps __.nullOrValue(charset) (a charset is a name, never a non-string).

Test on both engines

Adds a testGraalJs task (mirroring the platform's gradle/js-tests.gradle) that runs the existing suite under the GraalJS engine, wired into check. It needs the ScriptRunnerSupport fix from enonic/xp#12198, so xpVersion is bumped to 8.1.0-SNAPSHOT and the repo is switched to xp.enonicRepo('dev').

Local verification

Built the platform branch enonic/xp@claude/graaljs-support-limitations-pzu6z8 (which carries #12198) to mavenLocal, added mavenLocal() locally, then ran ./gradlew test testGraalJs:

• before the fix (property writes, GraalJS) — testGraalJs fails, e.g. PolyglotException at .../text-encoding.js:18
• after the fix — both engines green:
  • test (Nashorn): 82 tests, 0 failed
  • testGraalJs (GraalJS): 82 tests, 0 failed

CI status

⚠️ testGraalJs will stay red in CI until enonic/xp#12198 is merged and a fresh 8.1.0-SNAPSHOT is published. The snapshot currently on repo.enonic.com/dev still carries the old ScriptRunnerSupport, which closes the script executor during test discovery. This PR is kept draft until then; the Nashorn test task stays green.

[rymsha]

CI ran on 651cf77ed3e5fed063850dbaee85359997ac4829 — run 30430108773:

• :test (Nashorn) — green
• :testGraalJs (GraalJS) — 82 tests, 82 failed → BUILD FAILED

That 82/82 is the pre-#12198 signature: the 8.1.0-SNAPSHOT currently on repo.enonic.com/dev still carries the old ScriptRunnerSupport, which closes the script executor during test discovery, so every spec fails before it runs. Against a local platform build that includes enonic/xp#12198, all 82 pass on both engines. Kept draft until a fresh snapshot with #12198 is published; the red build check is expected until then.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.57%. Comparing base (5613d07) to head (afc639c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master     #157   +/-   ##
=========================================
  Coverage     96.57%   96.57%           
  Complexity       75       75           
=========================================
  Files            11       11           
  Lines           146      146           
  Branches          4        4           
=========================================
  Hits            141      141           
  Partials          5        5           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.