Repository navigation
security!: require zod 4 (clashcode 2.0.0) - #11
Merged
Merged
Conversation
Member
Author
|
Maintainer decision: release as 2.0.0 (major), zod 4 as a regular dependency. Added changeset + |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9. Dependabot opened new zod alerts after #9 merged.
Resolved
<4.6.6).Code change
src/core/clash-engine/tool-vault.ts: zod 4 typesZodOptional.unwrap()/ZodArray.elementas core$ZodType, so twoas z.ZodTypecasts are needed. No runtime change.Needs a maintainer decision (not auto-merged)
defineTool()is exported and takes a zod schema.zodToJsonSchemarelies oninstanceof z.ZodObject, etc. After this change, consumers who pass zod 3 schemas will get type errors and fall through to{type:'string'}at runtime. This is effectively a breaking change for library users, so it probably needs a changeset and a major/minor version bump.Verification
pnpm format:check,pnpm lint,pnpm build,pnpm test(445 pass),pnpm test:eval(7 pass),pnpm audit: no known vulnerabilities