Skip to content

fix: resume EVM to Miden deposits - #12

Open
Abhimanyu121 wants to merge 1 commit into
mainfrom
codex/fix-miden-withdraw-resume
Open

Abhimanyu121 wants to merge 1 commit into
mainfrom
codex/fix-miden-withdraw-resume

Conversation

@Abhimanyu121

@Abhimanyu121 Abhimanyu121 commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

Summary

  • renders explicit Compact lifecycle status instead of leaving the user at “awaiting signature” after approval or deposit confirmation
  • persists the exact prepared allocator request in browser storage once the Compact deposit receipt is confirmed
  • on reload, safely retries only the idempotent allocator submission; it never asks the wallet to deposit again
  • clears the pending record once the allocator accepts the intent

Why

A confirmed EVM-to-Miden Compact deposit could appear stuck while the server-side allocator hand-off was delayed or the page reloaded. This PR makes the real stage visible and gives the user a safe resume path.

Validation

  • Type-check attempted; it remains blocked by the pre-existing installed viem type-version mismatch in src/lib/epoch-sdk.ts.

Dependency

Requires the recovery-flow SDK/API changes in https://github.com/epochprotocol/smallocator/pull/57. The nonce multicall change in https://github.com/epochprotocol/smallocator/pull/58 is intentionally independent.

@vercel

vercel Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
miden-integration-example Error Error Sep 22, 2026 8:21am UTC

@github-actions

Copy link
Copy Markdown

React Doctor found 1 new issue in 1 file · 1 warning · score 92 / 100 (Great) · 1 fixed · vs main

1 warning

src/components/crosschain/WithdrawForm.tsx

  • ⚠️ L37 React function has high control-flow complexity no-high-complexity-react-function

Reviewed by React Doctor for commit f4fdf57. See inline comments for fixes.

resourceLockStatus?: ResourceLockStatus | null;
}

export function WithdrawForm({

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React Doctor · react-doctor/no-high-complexity-react-function (warning)

WithdrawForm has cyclomatic complexity 20, cognitive complexity 15, and maximum nesting depth 2, so its React logic is hard to understand and change. Extract independent branches into components or hooks.

Fix → Extract independent render branches and state logic into focused components or hooks until the control flow is easy to follow.

Docs

This branch had an error being deployed

1 failed deployment
Preview — f4fdf57e Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant