Repository navigation
chore: release v0.6.1 - #103
Merged
Merged
Conversation
Moves the SDK pin from main@cb814ad to the v0.5.1 tag, and bumps every version
location. A consumer release must name an SDK release, so the pin had to stop
being a main commit before this could be tagged; v0.5.1 exists for that reason
and carries nothing but the fix below.
A patch: both changes since v0.6.0 are bug fixes.
What it ships:
- includeHidden=false was read as true, so hidden people were returned to
every client on every call (#100). Fixed server-side in #101, because that
schema is declared here rather than in @imogen/shared.
- The same defect in the SDK's own schemas meant ?trashed=false returned only
trashed assets, ?favorite=false only favourites, and an upload carrying
favorite=false was favourited (#102). That half could only be fixed by
moving the pin, which is what this release delivers to users.
The ^0.5.0 ranges still admit 0.5.1, so no manifest range moves and bun.lock
needs no regeneration -- verified both before and after.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin move to the v0.5.1 tag plus the version bump, in one PR because both are release mechanics for the same patch.
Why v0.5.1 of the SDK exists
The wire-boolean fix landed on SDK
mainascb814ad, and #102 pinned the server there — legal between releases. But a consumer's release must name an SDK release, so shipping this meant cuttingimogen-sdk v0.5.1first and moving the pin onto the tag. That SDK release carries nothing but the fix.git submodule statusnow readsimogen-sdk (v0.5.1). The only difference between the tag and themaincommit it replaces is version files — verified by diffing them.What this ships to users
Two live correctness defects in v0.6.0, both wire-boolean truthiness, both measured rather than inferred:
?includeHidden=falsewas read astrue(#100, fixed in #101). Every SDK port defaultsincludeHiddentofalseand sends it, so an ordinarypeople.list()carried?includeHidden=false— which arrived astrueand went straight tolistPeople. Hiding a person never hid them. That schema is declared here rather than in@imogen/shared, so it needed a server-side fix.The same defect in the SDK's own schemas (#102) meant:
?trashed=falsereturned only trashed assets?favorite=falsereturned only favouritesfavorite=falsewas favouritedReachable from the shipped Rust client. That half could not be fixed here — redeclaring the SDK's fields is what CLAUDE.md forbids — so moving the pin is what actually delivers it.
Ranges and lockfile
The
^0.5.0ranges already admit0.5.1, so no manifest range moves.bun.lockneeds no regeneration — confirmed before and after the bump, diff empty both times.Verification
plus
bun run --filter '@imogen/web' buildexit 0, run both at the pin move and again after the version bump.sdk-contract.test.ts— the only place the SDK and server meet — passes against the tag.Review
Exempt: the pin move's substance was reviewed in #102, including an independent confirming review that re-derived its claims rather than accepting them (it verified the
?trashed=falsechain through four independent links, swept the generated OpenAPI document foranyOfregressions, and overruled two reviewers on a.meta()claim it could not reproduce). This PR adds the tag move and version strings on top of that.🤖 Generated with Claude Code