Repository navigation
build(docker): take a prebuilt web dist - #119
Merged
Merged
Conversation
The server image copies packages/web/dist and no longer compiles the UI. packages/web stays in the repo and still builds on its own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The server image compiled
packages/webduringdocker build. It now takes an already-builtpackages/web/distand copies that bundle.packages/webstays in the repo and still builds on its own.Scope
Dockerfileno longer runs the web build. It installs production dependencies and requirespackages/web/dist/index.html..dockerignorelets that dist into the build context. Otherdisttrees stay out.docker-compose.ymlnotes the dist prerequisite.Out of scope: moving the PWA, SDK changes, and any other issue.
Tradeoffs
A named Docker build context would also pass the dist in. Re-including
packages/web/distkeepsdocker build -t imogen .once the bundle exists, so compose does not grow a second context.Blast Radius
An image build fails until
packages/web/distexists. CI builds that bundle first. The runtime still servespackages/web/dist. The web package source and its build script are unchanged.Verification
On thor:
bun run --filter '@imogen/web' build, thendocker build --progress=plain -t imogen-server:prebuilt-dist-proof .. The build log does not run the UI compile. A marker file written only into the prebuilt dist is in the image at/app/packages/web/dist/PROOF_DIST_INPUT.txt.