Repository navigation
Remove the embedded web app source - #120
Merged
Merged
Conversation
The PWA lives in imogen-pwa. The image copies a supplied web-dist and does not compile a UI. The SDK submodule stays.
The checkout has no web-dist, and the image does not compile a UI. The docker job checks out imogen-pwa main with its SDK submodule and copies the build into web-dist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/web. The React app now lives in imogen-pwa (main@17b1d2c4d5e6b756d8d2a2ac2b641108a9ac9dd0).web-dist/(index.htmlat the top). The image copies that topackages/web/dist, which is where the server reads it, and does not compile a UI.@imogen/web. Theimogen-sdksubmodule and the@imogen/shared/@imogen/sdkimports are unchanged.The GitHub docker job has no
web-distin the checkout. This PR does not add a fetch or a UI build, so that job fails closed until a bundle is in the build context.Proof
On thor,
docker build -t imogen-remove-web-proof .with a suppliedweb-dist/completed with no Vite or@imogen/webstep. The image contains the suppliedpackages/web/dist/index.htmland nopackages/websource.bun --evalinside the image still resolvesERROR_CODESfrom@imogen/sharedandOAuthClientfrom@imogen/sdk.