Repository navigation
American spelling - #32
Merged
Merged
Conversation
Fix British spellings in comments, docs, task notes, two ColorPicker labels, a private view property (targetAcknowledgment) and four test names. The Apple API spellings Task.isCancelled and NWBrowser.State.cancelled stay as they are, each line marked with spelling: ok. Claude-Session: https://claude.ai/code/session_01XGS7UUxZFhvaK4bnErEfvW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the repo pass the org's American spelling check (
scripts/american_spelling.pyfromericdahl-dev/.github). It now printsAmerican spelling: OK.Fixed (53 hits, 33 files)
tasks/notes and test messages: grey, labelled/labelling, behaviour, recognised, colour(s), acknowledgement, modelling, signalling, honouring, materialised, generalising, centralising, cancelling.ColorPickerlabels are now "Beat color" and "Accent color".targetAcknowledgement->targetAcknowledgment(FirmwareUpdateSheet), and four test method names (..._capitalized_instance_name,test_setup_and_canceled_are_not_errors,..._still_grays_the_button,..._setup_aps_are_recognized).Kept as-is
No allowlist file. Six lines that use Apple's own spelling carry an inline
// spelling: okmarker instead of allowlisting the common word "cancelled":Task.isCancelled(DeviceDetailViewModel, DeviceListViewModel, KSControls x2)NWBrowser.State.cancelled(DiscoveryStatus, DiscoveryStatusTests)No UserDefaults keys, Codable keys or firmware wire values were touched.
Tests
xcodegen generate+xcodebuild teston the iPhone 17 Pro simulator, same command as CI: 148 tests, 0 failures.https://claude.ai/code/session_01XGS7UUxZFhvaK4bnErEfvW