Repository navigation
Sheet text and errors use the Palette (#252) - #313
Merged
Merged
Conversation
…rance (#252) Assisted-by: Claude Code:claude-opus-5-5 Claude-Session: https://claude.ai/code/session_01S6amVoNeB4GahnMMe79dZ6
Skeyelab
enabled auto-merge (squash)
October 11, 2026 04:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #252 (with #310, which made sheets follow the Appearance at once).
Palette.inlineText(.error/.warning, mode:, systemDark:): error and warning text for sheets, at least 4.5:1 on the sheet's background in Sunlight, Dark and System (light and dark). The system's red and orange are about 3.5:1 on white..errorText(),.warningText(),.inlineText(_:)and the existing.secondaryText()replace.foregroundStyle(.red/.orange/.secondary)in every sheet: Settings, Shows, Show detail, Channel names, the delete sheet, Markers, the Show sheet, the Trial and paywall, Pro, Find mixers. The Delete button keeps its red tint (a button, not text).Test first:
inlineProblemText(AppearanceTests)../scripts/verify.shpasses.Screenshots (Simulator, iPhone 17 Pro, Sunlight and Dark): Settings, Shows, Channel names, the delete sheet and the Armed record screen. All read correctly, and "No Drive copy" uses the new warning color. The Mac screenshots from #95/#98 (Mac Armed, Mac Settings) are still owed.
https://claude.ai/code/session_01S6amVoNeB4GahnMMe79dZ6