Repository navigation
A route change during a Take keeps its sample rate - #314
Merged
Merged
Conversation
…48 kHz Found by the whole-app review: a regression from #308. Assisted-by: Claude Code:claude-opus-5-5 Claude-Session: https://claude.ai/code/session_01S6amVoNeB4GahnMMe79dZ6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression from #308 (#195), found by the whole-app review:
moveTakeToCurrentRoute()(iOS, a route change mid-Take) calledSessionAudioDevice.current(), whose default asks iOS for 48 kHz. During a 96 or 44.1 kHz Take,restartInputthen saw a new rate and stopped the Take. It now asks forrecorder.sampleRate, as the media-reset path already did../scripts/verify.shpasses. No test seam for this iOS session path; not checked on a device (needs a USB hub blip during a 96 kHz Take on an iPhone).https://claude.ai/code/session_01S6amVoNeB4GahnMMe79dZ6