Repository navigation
A failed record press no longer blocks the next one (#315) - #326
Merged
Merged
Conversation
…ls at the press falls back to the Device (#315) Assisted-by: Claude Code:claude-opus-5-5 Claude-Session: https://claude.ai/code/session_01S6amVoNeB4GahnMMe79dZ6
Skeyelab
enabled auto-merge (squash)
October 11, 2026 05:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #315 (blocker from the whole-app review).
Before:
startTakecreated the next Take folder on a copy of the Show and stored the Show only at the end. If anything after the folder failed (TakeSession, a Stem, the metadata), the next press got the same Take number, found the folder, and threw "file exists" until a relaunch or End Show. A Drive that failed at the press blocked recording outright, and a failure after the Drive was opened never let it go.Now (
Recorder.openTake, one attempt that undoes itself):Tests, written first (
FailedPressTests):./scripts/verify.shpasses (431 tests). Not checked on a device (a full Device or a read-only Drive at the press).https://claude.ai/code/session_01S6amVoNeB4GahnMMe79dZ6