Repository navigation
On an iPhone, Markers, Channel names and Settings open as a panel, not over Stop (#250) - #329
Merged
Merged
Conversation
…t a sheet over Stop (#250) Portrait: the panel takes the meters' place and the transport stays below it. Landscape: the panel sits beside the meters, which get narrower but keep their height. iPad and Mac keep sheets until #255. LivePanelPlacement (Kit, tested) picks the place from the size classes. - Tapping a channel label on an iPhone opens the Channel names panel instead of a modal alert with a keyboard over Stop and Marker - Channel numbers stay on one line, so a narrowed "10" can't make its meter shorter - -showSettings and -channelNames open the way a tap does; new -showMarkers Assisted-by: Claude Code:claude-opus-5-5 Claude-Session: https://claude.ai/code/session_013qdugNZbXwKKz5gPzzi2CL
Skeyelab
enabled auto-merge (squash)
October 11, 2026 05:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #250 (iPhone). The iPad and Mac panels are #255.
What changed
LivePanelPlacement(Kit, tested first) chooses over the meters, beside them, or a sheet, from the size classes.-showSettingsand-channelNamesnow open the same way a tap does. New-showMarkers, for screenshots.How it was checked
LivePanelPlacementTests: portrait, landscape (small and Max) and regular width. Written first; they failed before the type existed.-demoSignal -demoRecord):./scripts/verify.shpasses: 434 package tests, macOS and iOS Simulator builds.Already there before, not changed here
https://claude.ai/code/session_013qdugNZbXwKKz5gPzzi2CL