Skip to content

refactor: return structured code path data without JSON serialization - #530

Open
electrohyun wants to merge 1 commit into
eslint:mainfrom
electrohyun:refactor/remove-code-path-json-serialization
Open

refactor: return structured code path data without JSON serialization#530
electrohyun wants to merge 1 commit into
eslint:mainfrom
electrohyun:refactor/remove-code-path-json-serialization

Conversation

@electrohyun

@electrohyun electrohyun commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Prerequisites checklist

AI acknowledgment

  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request?

Remove JSON serialization from code path generation.

What changes did you make? (Give an overview)

Returned the code path array directly through the response and updated the caller to use it without JSON.parse().

Related Issues

refs #519

Is there anything you'd like reviewers to focus on?

x

Disclosure: I'm a participant of open source contribution program OSSCA

Summary by CodeRabbit

  • Bug Fixes
    • Improved code path handling for more reliable path counts and DOT output selection.
    • Updated code path results to display correctly using the returned data directly.

@netlify

netlify Bot commented Sep 1, 2026

Copy link
Copy Markdown

Deploy Preview for eslint-code-explorer ready!

Name Link
🔨 Latest commit e48d957
🔍 Latest deploy log https://app.netlify.com/projects/eslint-code-explorer/deploys/6a96885101a96a0008b254e3
😎 Deploy Preview https://deploy-preview-530--eslint-code-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@eslintbot eslintbot added this to Triage Sep 1, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in Triage Sep 1, 2026
@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: bdac8a53-0ace-4819-a3bb-b15bae9e43e6

📥 Commits

Reviewing files that changed from the base of the PR and between 0b98cc4 and e48d957.

📒 Files selected for processing (1)
  • src/components/path/index.tsx

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

generateCodePath now returns typed CodePathData[] values directly. The CodePath component removes JSON parsing and reads path counts and DOT output from the returned array.

Changes

Code path response handling

Layer / File(s) Summary
Typed response contract
src/lib/generate-code-path.ts
Adds CodePathData and returns mapped code path data directly without JSON serialization or a codePathList wrapper.
Path component consumption
src/components/path/index.tsx
Consumes the typed array for path counts, index synchronization, and selected DOT output.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to e48d9

This PR removes JSON serialization from code-path generation and updates its caller to use the structured data directly; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: returning structured code path data without JSON serialization.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@electrohyun
electrohyun force-pushed the refactor/remove-code-path-json-serialization branch from 0b98cc4 to e48d957 Compare September 1, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants