Skip to content

fix: update baseline data - #566

Open
Pixel998 wants to merge 1 commit into
mainfrom
fix/update-baseline-data
Open

Pixel998 wants to merge 1 commit into
mainfrom
fix/update-baseline-data

Conversation

@Pixel998

@Pixel998 Pixel998 commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Prerequisites checklist

AI acknowledgment

  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request?

Updates baseline data to web-features@3.38.0 and fixes the generator so url() keeps its widely available status.

web-features 3.38.0 adds the link-parameters feature with the compat key css.types.param.url. The generator read it as the url() function and overwrote the status from css.types.url.

What changes did you make? (Give an overview)

  • Bumped web-features to ^3.38.0 and regenerated the baseline data.
  • A function's own css.types.<name> key now takes precedence over css.types.<group>.<name> keys and feature-name matches.
  • Added shape to the list of bare type keys that aren't functions, since css.types.shape is the deprecated <shape> type, not shape().

Related Issues

Closes #564

Is there anything you'd like reviewers to focus on?

Summary by CodeRabbit

  • Compatibility Updates
    • Updated browser support information for several CSS features, including rx, ry, text-wrap, and percentage-based text-decoration-thickness.
    • Added compatibility data for the link-parameters property and param() function.
    • Improved compatibility reporting for CSS functions, including more accurate handling of shape().

@github-project-automation github-project-automation Bot moved this to Needs Triage in Triage Sep 14, 2026
@eslint-github-bot eslint-github-bot Bot added the bug Something isn't working label Sep 14, 2026
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 4a318ba2-9148-4ade-8819-9d60ee5d7560

📥 Commits

Reviewing files that changed from the base of the PR and between 876e8b1 and 91ad400.

📒 Files selected for processing (3)
  • package.json
  • src/data/baseline-data.js
  • tools/generate-baseline.js

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The update refreshes CSS compatibility data from web-features 3.38.0. It adds link-parameters and param, upgrades several support statuses, and changes baseline generation precedence for function compatibility keys.

Changes

CSS baseline data

Layer / File(s) Summary
Compatibility extraction rules
tools/generate-baseline.js
The generator treats shape as a non-function type. Bare function compatibility keys take precedence over grouped keys and feature-name matches.
Regenerated compatibility baseline
package.json, src/data/baseline-data.js
The web-features dependency is updated to ^3.38.0. The baseline adds link-parameters and param, preserves the relocated shape entry, and upgrades support for rx, ry, text-wrap, and percentage text-decoration-thickness.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: eslintbot

Merge Risk: ⚪ Minimal · up to 91ad4

The compatibility refresh has no identified current-head failure and is ready to merge after normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: fixing baseline-data generation and updating the generated baseline data.
Linked Issues check ✅ Passed The changes satisfy the coding objectives in issue #564. package.json updates web-features to ^3.38.0. src/data/baseline-data.js adds link-parameter and parameter-function compatibility data a…
Out of Scope Changes check ✅ Passed The reviewed changes stay within issue #564. The dependency update, regenerated baseline data, and generator corrections all directly support the baseline data update. No unrelated product behavior or…
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 …
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/update-baseline-data

Warning

Some tools did not complete. Review the errors below.

🔧 ast-grep (0.45.3)
src/data/baseline-data.js

ast-grep timed out on this file


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Pixel998 Pixel998 moved this from Needs Triage to Implementing in Triage Sep 14, 2026
const { group, type } = match.groups;
if (isCompatTypeAFunction(group, type)) {
output.functions[type] = mapFeatureStatus(status);
if (!group) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this logic would be easier to understand like this:

if (!functionsFromBareKeys.has(type)) {
	output.functions[type] = mapFeatureStatus(status);
}

if (!group) {
	functionsFromBareKeys.add(type);
}

The logic should be equivalent (currently produces the same output).

@DMartens DMartens added the accepted There is consensus among the team that this change meets the criteria for inclusion label Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion bug Something isn't working

Projects

Status: Implementing

Development

Successfully merging this pull request may close these issues.

2 participants