Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe update refreshes CSS compatibility data from ChangesCSS baseline data
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The compatibility refresh has no identified current-head failure and is ready to merge after normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 ast-grep (0.45.3)src/data/baseline-data.jsast-grep timed out on this file Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| const { group, type } = match.groups; | ||
| if (isCompatTypeAFunction(group, type)) { | ||
| output.functions[type] = mapFeatureStatus(status); | ||
| if (!group) { |
There was a problem hiding this comment.
Maybe this logic would be easier to understand like this:
if (!functionsFromBareKeys.has(type)) {
output.functions[type] = mapFeatureStatus(status);
}
if (!group) {
functionsFromBareKeys.add(type);
}The logic should be equivalent (currently produces the same output).
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
Updates baseline data to
web-features@3.38.0and fixes the generator sourl()keeps its widely available status.web-features 3.38.0 adds the
link-parametersfeature with the compat keycss.types.param.url. The generator read it as theurl()function and overwrote the status fromcss.types.url.What changes did you make? (Give an overview)
web-featuresto^3.38.0and regenerated the baseline data.css.types.<name>key now takes precedence overcss.types.<group>.<name>keys and feature-name matches.shapeto the list of bare type keys that aren't functions, sincecss.types.shapeis the deprecated<shape>type, notshape().Related Issues
Closes #564
Is there anything you'd like reviewers to focus on?
Summary by CodeRabbit
rx,ry,text-wrap, and percentage-basedtext-decoration-thickness.link-parametersproperty andparam()function.shape().