Skip to content

crates/models: resolve capture interval from the connector tag - #3333

Open
nicolaslazo wants to merge 1 commit into
masterfrom
nlazo/fix-use-default-capture-interval-col
Open

crates/models: resolve capture interval from the connector tag#3333
nicolaslazo wants to merge 1 commit into
masterfrom
nlazo/fix-use-default-capture-interval-col

Conversation

@nicolaslazo

Copy link
Copy Markdown
Contributor

Description:

connector_tags.default_capture_interval has existed for a long time but nothing ever applied it.

interval becomes Option<Duration>, with unset meaning "resolve at build time". If the model does not provide its own interval, then the connector tag's takes precedence over the global fallback.

Build-time resolution costs propagation latency: a changed tag default reaches an existing capture only when that capture is next built. That happens automatically within twenty days via the periodic touch publication, and sooner if anything else republishes the task.

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

Tested locally using unit tests.

`connector_tags.default_capture_interval` has existed for a long time
but nothing ever applied it.

`interval` becomes `Option<Duration>`, with unset meaning "resolve at
build time". If the model does not provide its own `interval`, then the
connector tag's takes precedence over the global fallback.

Build-time resolution costs propagation latency: a changed tag default reaches
an existing capture only when that capture is next built. That happens
automatically within twenty days via the periodic touch publication, and sooner
if anything else republishes the task.
@nicolaslazo
nicolaslazo requested a review from a team August 10, 2026 17:59
@nicolaslazo nicolaslazo self-assigned this Aug 10, 2026
@github-actions

Copy link
Copy Markdown

@jgraettinger

jgraettinger commented Aug 10, 2026

Copy link
Copy Markdown
Member

What about resolving this from the Spec response, Open response, or an image label? For example we change validation semantics so that "unset" propagates down into the built spec, and then have the reactor choose the restart interval through a negotiation with the started connector.

It seems circuitous to have connector_tags control this, given it's a property of the connector, and I have uncertainty about how fit-for-purpose connector_tags will remain going forward.

@jwhartley

Copy link
Copy Markdown
Contributor

Docs have moved, and this PR straddles the split. The code belongs here; the
doc files no longer do.

estuary/flow's site/ tree is no longer published. docs.estuary.dev is
served from estuary/docs (platform docs, under content/), which aggregates
connector pages from estuary/connectors (under docs/reference/Connectors/)
at build time.

Suggested split:

  • Keep the code changes in this PR and drop the doc files from it.

  • Open the doc half against estuary/docs, where these paths map across:

    • site/docs/concepts/captures.md becomes content/concepts/captures.md

Flagging it because the doc half would otherwise merge into a tree nobody
serves. The "docs.estuary.dev: Deploy" check will still go green, which is
deliberate (it keeps flow's gh-pages rollback artifact current until
2026-09-30) and is not a signal that the doc change shipped.

Context: migration announcement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants