Add keymanager builder for ePBS - #2829
Open
yorickdowne wants to merge 1 commit into
Open
yorickdowne wants to merge 1 commit into
yorickdowne wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Support the keymanager builder API. https://ethereum.github.io/keymanager-APIs/?urls.primaryName=dev#/Builder%20Config/setBuilderConfig
It has a lot more options than graffiti/gas, which are just a value each. Yet most users will at most want to set some urls and a min-bid, and maybe boost factor.
To handle that, I expose the simple path, then have a way to print it all to
--jsonand get it--from-json, where a user could have a fully formed builder config.Added
0xpubkey1,0xpubkey2form for validator pubkeysbuilder URLs right now have no pubkeys in the simple form. I need to see how pubkeys will be used with Glamsterdam before making a decision, that would be a follow-up PR. I expect we won't see what builders do until Hoodi.
Follow-up PRs are:
[pubkey@]urlform for builders, if pubkeys become common0xpubkey1,0xpubkey2for all otherethd keyscommands where it makes sense, such as gas and graffiti.envsupportlocal,maxprofitandalwaysforEPBS_BUILD_FACTOR, and migrate100toalwaysduringethd update, once during transitionPR description human
The code was written by Claude Opus 5