Skip to content

Fix geth attach and volume regexes - #2830

Open
yorickdowne wants to merge 1 commit into
ethstaker:mainfrom
yorickdowne:fix/volume-regex-match
Open

yorickdowne wants to merge 1 commit into
ethstaker:mainfrom
yorickdowne:fix/volume-regex-match

Conversation

@yorickdowne

@yorickdowne yorickdowne commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

What I did

I am testing for volume existence with [[ -n "$(__dodocker volume ls -q -f "name=${vol}")" ]] and analogous for non-existance -z. This is not ideal because it's a regex and can give me false positives. docker inspect is better for just existence. For volume ID a bit more is needed

Examples: Directory eth.docker doesn't match any volumes it should but will match eth-docker; directories eth-docker and test-eth-docker will overmatch volume names inside eth-docker

Geth attach hard-codes an old volume name and always failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant