Fix geth attach and volume regexes - #2830
Open
yorickdowne wants to merge 1 commit into
Open
yorickdowne wants to merge 1 commit into
yorickdowne wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
I am testing for volume existence with
[[ -n "$(__dodocker volume ls -q -f "name=${vol}")" ]]and analogous for non-existance-z. This is not ideal because it's a regex and can give me false positives.docker inspectis better for just existence. For volume ID a bit more is neededExamples: Directory
eth.dockerdoesn't match any volumes it should but will matcheth-docker; directorieseth-dockerandtest-eth-dockerwill overmatch volume names insideeth-dockerGeth attach hard-codes an old volume name and always failed