Chunking deposit simulation requests due to WC data limit - #274
Open
valefar-on-discord wants to merge 1 commit into
Open
valefar-on-discord wants to merge 1 commit into
valefar-on-discord wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing 50+ deposits, I ran into an issue where the simulation would always fail with a 403. This is because we rely on walletconnect to perform this action and they have a limit to the amount of data they can process, about 12 deposits worth.
To get around this we will batch deposits & top-ups in chunks of 10 when simulating but will still send the entire batch at once with signing.
I tested to see if there was any rate limit and I didn't find any documentation nor hit any restriction with 50+ concurrent requests.